Log of /moodle/course/edit.php

course-edit MDL-20204 Fixed recent regression get_list_of_themes returns array of themes now not strings

MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions

MDL-20790 more page layouts -see base theme for full list; also added new css body class for describing current layout; base layout is now default for beter BC; require_login() now sets 'incourse' layout automatically

MDL-20204 first batch of major theme changes, some regressions are still there, expect more changes and improvements soon; see tracker for details and list of subtasks

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

files MDL-20601 Conversion of many of the uses of print_textarea, and the mforms htmleditor to the new editor
Please forgive me if I have missed converting any output statements. If you do find an output statement that is not formatting correctly please refere to the table I added to this bug in regards to how it should be formatted.

questions MDL-19820 Added set_url calls

navigation MDL-20216 Refactored add arguments
Moved $action argument from arg5 to arg2

course MDL-19794 Upgraded print_header and build_navigation calls to use PAGE and OUTPUT equivilants

MDL-19794 Converted all print_footer() calls

MDL-19794 Migrated calls to print_heading

themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme

The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)

Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)

The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.

How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.

Further refinement for how the theme and block code gets initialised.

Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)

Things that are still broken:
 * some pages in lesson, quiz and resource. I'm working on it.
 * lots of developer debug notices pointing out things that
   need to be updated.

blocklib: MDL-19010 always include blocklib in setup.php, stip includes elsewhere

course settings: MDL-18595: Fix regression caused by switching the course settings form to use the new date selector.

The bad commit was http://cvs.moodle.org/moodle/course/edit_form.php?r1=1.65&r2=1.66

Sorry everyone who was inconvenienced by this.

MDL-9983, MDL-13998 core events related cleanup; merged from MOODLE_19_STABLE

MDL-9983, MDL-13998, MDL-15552 core events related cleanup and potential sql injection problem fixed; please note the changes are not backwards compatible, 3rd party code will need to be updated  - sorry for the trouble

MDL-15189 magic quotes finally removed

MDL-14679 datalib conversion completed

"MDL-14129, fix print_error call under course/, see tracker"

MDL-14129, remove all the other error() call

MDL-12409 - stop access to editing 'site course' with course edit form.

Merged from MOODLE_19_STABLE

MDL-12409 - stop access to editing 'site course' with course edit form.

course/edit: mark the course contextpath as dirty to force a reload

Combined with the path creation in create_context() we can now create
a course, enter and edit it immediately. Amazing.

Like - 21st century technology.

Merged fixes for MDL-10833 from HEAD

MDL-10870 All files updated to new build_navigation() method.

Make course themes work on course settings page MDL-10833

MDL-9983, adding triggers for certain events, no handler implemented

MDL-9929 we need some other name for password field in course edit page

Restoring changes all the changes in MOODLE_16_STABLE since MOODLE_16_BETA.

This had to be done because the MOODLE_16_STABLE branch tags were moved.

Hopefully after this MOODLE_16_STABLE will be back to how it was (and a
proper branch) but some of the history may look a bit odd.

See MDL-9032 for more discussion and details.

Merged create_course and update_course changes from head   MDL-9015

Moved create_course and update_course into course/lib.php and cleaned them up to be more useful in general  MDL-9015

fix for MDL-8966, customizable role names

MDL-8867 Add setting to define role that is assigned to creators in new courses
MDL-8868 Set only minimal permissions for creator role

+ improved accesslib to handle changes of context levels in capability definitions

merged from MOODLE_18_STABLE

MDL-8867 Add setting to define role that is assigned to creators in new courses
MDL-8868 Set only minimal permissions for creator role

+ improved accesslib to handle changes of context levels in capability definitions

Merged Nicolas' changes from MDL-8582 into HEAD.

Fixed MDL-8582
Not sure if the hotpot module is converting ampersands correctly. $heading and $title are set up differently than in other modules: instead of outputting $course->title, a temporary $title variable is created and assigned that value. That made it difficult for me to decide whether it was already formatted elsewhere or not.

Also I didn't format_string() any of the variables included in $navigation rings, because I assume these strings get processed by print_navigation(), which includes format_string().

Merged from 1.8.

Merged from 1.7.

Fix for MDL-7796 "Default permissions for Course Creators are too permissive". Changed some permissions from allow to inherit. Changed course deletion checks to allow course creators to delete courses.

MDL-8166 rename in/out methods in formslib - HQ consensus

moved set_defaults to main script out of definition method.

* Added setAdvanced functionality see http://docs.moodle.org/en/Development:lib/formslib.php_setAdvanced
* Added MoodleQuickForm method closeHeaderBefore($elementName); http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#Use_Fieldsets_to_group_Form_Elements
* Added moodleform method add_action_buttons(); see http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#add_action_buttons.28.24cancel_.3D_true.2C_.24revert_.3D_true.2C_.24submitlabel.3Dnull.29.3B
* is_cancelled method added to moodleform http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page
* added hidden labels to elements within groups such as the date_selector select boxes and other elements in 'groups'
* quiz/mod.html migrated to formslib
* glossary/edit.html migrated to formslib
* extended registerNoSubmitButton() functionality to automatically add js to onclick to bypass client side js input validation.
* added no_submit_button_pressed() function that can be used in a similar way to is_cancelled() as a test in the main script to see if some button in the page has been pressed that is a submit button that is used for some dynamic functionality within the form and not to submit the data for the whole form.
* added new condition for disabledIf which allows to disable another form element if no options are selected from within a select element.
* added default 'action' for moodleform  - strip_querystring(qualified_me()) http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page

fix for MDL-7540 wrong usage of context levels

coding style fixes MDL-6949

course/edit.php now uses new forms lib, the old one is gone; please report any problems in MDL-6949

refactored course/edit2.php and edit_form MDL-6914 ; set $CFG->use_new_forms=1; in config.php if you want to test it ;-)

major whitespace cleanup - fixed tabs

replacing deprecated funciton calls with capability calls

moodle/course:managemetacourse is now singular

metacourse fixes for course editting

validation should not watch out for teacher and students string anymore

if the user has no capability, after creating a course we add him to the first role with legacy:edittingteacher, to make him a legacy editting teacher

$CFG->defaultcourseroleid defines a site default for the role given to
people who enrol in the course.

$course->defaultrole defines the value for each course for what role
should be used in the same case.   Naturally it defaults to the site config
(when it is zero).

This role is retained even when the person editing the course settings
doesn't actually have that role in their list of assignable rights (however
they are prevented from actually switching to any such role themselves).

Note that enrol plugins are free to ignore these values and use whatever
roles they like.  Generally, though, they should respect these settings.

some (mainly admin realated) capabilities

SWEEPING CLEANUP

The API was changed slightly so that has_capability now takes the
whole $context object (we almost always have it anyway)

The $kill thing was removed.   If you want to assert a capability
then use:

    require_capability('capname', $context);

with optional variables to modify the error message

Misc bugs here and there also removed and code tidied

Removed all of the "Restricted users" hack because Roles can do it all better.

ROLES AND PERMISSIONS  - FIRST CHECK-IN
=======================================

WARNING:  DEV IS CURRENTLY VERY UNSTABLE.

This is a mega-checkin of the new Roles system.   A lot of changes have
been made in core and modules.

Currently there are a lot of rough edges and known problems.  We are
working hard on these .. .the reason for getting this into HEAD at this
stage is enable us to move faster (our branch was diverging from HEAD
too much).

Please keep an eye on http://docs.moodle.org/en/Roles for current status
and information for developers on how to use the new Roles system.

Bug #6120 - Course creation - loginproblem; merged from MOODLE_16_STABLE

Bug #6120 - Course creation - loginproblem

Updated capabilities

Changed capability names to bring in line with format defined in wiki

group permission

bug #5347 - JS code after page end??? corrected

bug #5347 - JS code after page end??? corrected

changes needed for new s() and p() - see bug #2338

[multienrol]Initial commit for multi enrolment plugin feature

parameter cleaup - round 8;  short php tag in group-edit.html

Merged with MOODLE_16_MULTIENROL_MP1

cleaning of parameter, initialized variable SC#168; merged from MOODLE_15_STABLE

cleaning of parameter, initialized variable SC#168

Initial commit for multi enrolment plugin feature

New feature: Course enrollable control with date range

Course request feature. Allows normal users to 'request' courses they would like created,
and admins can approve or reject pending courses.

Also, contains the ability to restrict activity modules on a per course basic. Strict config options:
  enable restricting modules at ALL (for all courses, no courses, requested courses), what to do by default for newly created courses
  as well as what modules to enable for above category by default.

This feature was created for the aim of building a community side to moodle - for institutes that have strict courses and enrolments, allowing normal users to request interest courses is a good feature,
but some modules may be redundant (assignment, lesson, quiz etc)

  Please test!

Add currency to cost

Replaced require_variable(), optional_variable() with approproate
required_param(), optional_param() etc.

New courses are logged to the site log

Merged from MOODLE_14_STABLE - Provide an explicit sortorder for new courses in empty categories, and run fix_course_sortorder() after adding the course to make sure its in the appropriate range for the category. This mege adds fix specific to HEAD: it reverts an earlier bad fix.

Provide an explicit sortorder for new courses in empty categories, and run fix_course_sortorder() after adding the course to make sure its in the appropriate range for the category

Fixes for null sortorder on empty categories.

Dropping the use of MOODLE_PAGE_COURSE <gasp>!

The new constant is PAGE_COURSE_VIEW, and it's more streamlined with the
new CSS-related ids for 1.5. There are great possibilities for the future
here, so we 're getting ready.

On the other hand, this has to be the ugliest hack I 've ever inflicted
on any program (look at pagelib.php). Thankfully it will only stay for just
a little while.

Removed THEME from many course files

Merged from MOODLE_14_STABLE - Ensuring correct sortorder at the beginning of the category when creating courses.

Ensuring correct sortorder at the beginning of the category when creating courses.

Update for meta courses.   New table renamed from meta_course to course_meta (and upgrade script provided in mysql.php and postgres7.php) and new field in course table renamed from meta_course to metacourse.  Associated changes in code.  Please test me!

Initial checkin for new meta courses feature.  Please test!
See http://moodle.org/mod/forum/discuss.php?d=17269 for description.

Merged from MOODLE_14_STABLE - Closing SC#66

Closing SC#66

Fix for bug 2241:

I hope this time I got everything changed to the new Page interface! I 'm
really sorry for messing up and breaking new installations... :(

Also moved the only two functions of the API outside the page_base class.

MAJOR CHANGES:
--------------

Brand-new pagelib.php at your disposal! It slices, it dices, it makes your coffee.
It still doesn't understand women... Read the comments in pagelib.php for a first
impression. Feedback highly encouraged!

Blocks code has undergone significant changes to work with Pages. Flexibility is its
middle name, since I think (without having tried it) that adding e.g. a third
placeholder for "center" blocks in courses, with full support for moving around etc,
will now take about 15 lines of new or edited code. If you are not impressed yet, I
suggest watching a documentary on solar physics. :P

MINOR CHANGES:
--------------

Added instance_allow_config() in the blocks class hierarchy to supplement per-instance
configuration options. You can override it to return true and thus get configuration
amenities without allowing multiple instances.

Minor polishing to comments and documentation (whatever caught my eye was game).

Tightened up some code here and there by utilizing all the new features.

BUGFIXES:
---------

A bug in restore_execute.html caused hidden blocks to not be restored at all.

Da monster-commit of blocks version 2!

Code based on the work of Daryl Hawes for the blog module. Thanks, Daryl!

Please test the hell out of it as it's sure to have issues that need to be
ironed out.

course/edit.php is using sesskey.

Merged from MOODLE_14_STABLE

edit.php is using sesskey

provisional fix for bug reported by Timothy Allen in http://moodle.org/mod/forum/discuss.php?d=13388. Provisional because I am not sure I am using the new parameter functions correctly.

Added optional_param and required_param just to get it on the plate

Merged from STABLE

Use the new parameter() function to check parameters better

towards XHTML compliance

Added new default block definition functionality.

Fix for bug 1678:

When a course's format is changed, blocks which are not appropriate for the
new format are automatically purged.

Avoiding a notice

FIxed some notices

BRANCH MERGE

These are the changes from MOODLE_13_STABLE, merged into trunk

The tag MOODLE_13_MERGED on the MOODLE_13_STABLE branch now refers to this point

The biggest changes here are the fixes for HTML editor in all standard modules

OK, for bug fixes this is a pretty big checkin!!   :-/

I finally was able to see the HTML Editor bug in IE/XP that everyone
was talking about, and it's a very serious bug as it makes Moodle 1.3
almost unusable for these people.  :-(  :-(

So, I eventually found out that the problem is that the Javascript that
attaches the editor has troubles when it is embedded within the table                                                   that course/mod.php puts around the mod.html forms in each module.
(Only in IE and only sometimes, mind you).

While testing I also had a good look at a long standing issue which is the
inconsistency of the mod.html forms when using the editor.

So, to fix both I decided to put the HTML editor calls OUTSIDE the mod.html
in the mod.php file.  This means that all modules get the HTML editor by default
on all text areas during activity module setup by default.

I've been running through this for the past few hours and it seems
pretty stable now and a lot more consistent, so I'm checking it in
as big fix towards the Moodle 1.3.1 we have to have.

Unfortunately it also means the API has changed a bit  ... I had to
update all the module dependencies to this exact version (or later).

Please test this "stable" version hard using the standard modules only
and I'll merge these changes over to the trunk in a day or so and update
all known third-party modules.

List of courses is now always ordered according to sortorder, see http://moodle.org/mod/forum/discuss.php?d=7034

Fix for bug #1280: the "showrecent" course setting has to go.

Updated script and editing page.

First Official realease of the "Blocks System".
Integrated with Moodle:
    - Install automatically.
    - Update course->blockinfo for each course at installation time.
    - Modified course creation to insert into blockinfo field.
    - Modified restore to insert into blockinfo field.
    - Admin options (hide, show, delete, config) from admin page.
    - Lang strings inserted (en only).
    - Database support to mysql and postgresql (not tested!!).
Moodle, backup and block versions updated to 2004041800.
Tested with mysql: Install fresh and upgrade from previous.
section_activities block renamed to social_activities and created
its own lang file to support name "Social Activities". This can
be changed at any time.

TODO:
=====
Support it really in backup/restore.
????

Enjoy!! Ciao :-)

Restricted users can't update course formats

This is the first check-in of support for groups.

It's very early (it doesn't actually do anything yet!) but you can
define groups and get an idea of how the interface is shaping up.
I also wanted to show that I have actually done something on this! :-)

From here my plan is to add group support to the modules, one by one
(forums first), then go back and clean up some of the central interfaces,
graphics etc.

Finally, test, test, test and get 1.2 out well before the end of February.

Modification of the course format plugin structures so that it
fits in with other plugin formats in Moodle.

Initialized showgrades

If the language is the same as the site, then default to using the
same terminology as the site does

Put in buttons so that course creators can create courses!  :-I

Also, category fix_sorting is done better now when a course is added.

Teacher editors can edit courses, and course creators get
added as teacher-editors when they create a course

WARNING: BIG CHANGES!

OK, this is a big check-in with some big changes, and needs work still.

It seems relatively stable, but I need help identifying the rough patches.

1) First grading scales support.  There is a now a new table called "scale"
   that contains grading scales.  There can be site scales (course=0) and
   custom course scales.  These can be used in modules - I've only done
   forums for now but that was the hard one.  Scales can be edited via
   the new item in the course admin menu.

   There is one default scale - the connected/separate knowing one that used
   to be in forum.  To build this I pull data from the language packs
   to create one during the upgrade, or anytime a scales menu is called
   and no scales are found.

2) New roles for course creator and teachers.  I've fixed up the course
   menus and some other things but there's a lot left to do on this to
   make it all smooth.  The idea is that teachers no longer can edit courses
   unless they are also course creators.  The interface for this needs to
   be smoothed out a fair bit and I need help with this.

   The upgrade will upgrade all teachers to be creators, but will default
   the new site config "creatornewcourses" to "no", so that effectively
   these new teachers have the same privileges.

3) Simplified teacher management.  There is no longer an "assign teachers"
   and a "teacher roles" page - it's all on one page in course/teacher.html.


Phew ... time for a shower and then back into it.

More moodling on the course categories, improving performance for
large categories and making it easier to move large numbers of
courses around.

Also cleaned up some of the navigation bars

Little display tweaks

Another big checkin.

This includes some significant cleanups to the new course categories
system.  The basic idea is that the categories/course browser is now
unified under one system, and admin features related to that have
all been moved into the browser (as little icons).

I'm much happier with this as a foundation that can scale and be
built upon.

Still to go:

  - searching
  - paging
  - polishing

Also in here are a lot of little cleanups around the place, such as
the initial setup process.

COURSE DISPLAY REVAMP

OK, some big changes here to the front end, particularly in
course categories and course display.

Course categories can now be nested (to any level).

Courses and course categories can now be manually sorted
any way required.

There is a groovy front end for managing these, and a better
range of options for formatting the front page.

It all still needs some polishing, which I'll be doing over
the next couple of days, including better auto-sorting.

I would not use this on production systems just yet.

New course parameter "visible" which makes the course available to
students.  Defaults to 1 (on).  Teacher can control this from settings page.

A bit of an audit and a clean up of require_login to add consistency.

No major problems found, just some code tidy-up

Fixed up "Assign teacher" page, and moved it to admin directory.

Robustness for $course variable

New $CFG->admin directory can override the location of the admin
directory.

Useful because some web hosts use /admin for other things.

Courses are forced to have unique shortnames (see bug 299)

Removed save_session() - no longer needed.

Cleanups for course creator.

Redirect teachers to course after coursecreation.

Added support for nonadmin course creation.
Course creators are managed by /admin/creator.php , same way that admins.
Or if authetication module have 'auth_iscreator'-function (right now only ldap-module have) ,
users are added to creators at login time.

Password had no default

More fixes for robustness

Clean sweep through all the important changing all include(), include_once()
and require() to require_once()

buggy_referer is dead!   Long live buggy_referer!

Should be fixed now.  As a bonus, I've removed all the uses of
HTTP_POST_VARS from all scripts.

All forms should use the new data_submitted() function to collect
form data (it does the match_referer thing internally now).

Much nicer.

Robustness fixes

Many many changes lumped in here ... not finished yet either.

Basically all the Database functions are in lib/datalib.php
and the web functions are all in lib/weblib.php, so
moodlelib.php is much thinner than it was.

Data functions have been extended ... most old calls will
still work, but now many more SQL commands can be performed
using the datalib functions rather than using SQL.  I'm
currently moving through the whole tree replacing SQL
calls or at least concentrating them in one section of
mod/xxx/lib.php

Still working on forums, quizzes, surveys, resources.

The tree is currently not full working ... some things are
half-completed ... will resume tomorrow.

Default with showrecent ON

Tweaks to page titles to make them more consistent

Some consistency in headers on editing forms

Changes to allow much better control over what "teachers" are called
in a course.  Firstly, the course settings page now allows the teachers
to specify the word they want to use in place of "teachers" and "students"
as well as "teacher" and "student".  Secondly, a new teacher admin tool
allows any teacher to modify the order and displayed role of teachers
in that course.  This affects the display on the course listings, the
participants page and so on.

Changes related to language support  ... get_string()
Minor little interface cleanups along the way

Further excellent tidy-ups to the admin pages.  They are actually starting
to look/work as slick as the rest of the site.  :-)

MOre language updates

Lots of work on site display, over many files.  Improved front page
and display of site modules.

Much simpler date-setting using new moodlelib functions

More language changes

Consistent use of get_site() instead of checking course->category directly

Major changes throughout to change "week" notation to "section" notation.
Sections covers "weeks", "topics" and anything else that may come along.
Note, again, some databases have changed esp course_weeks -> course_sections
and several fields called "week" are now "section.  Also course no longer
has an enddate, but instead has a numsections field.

Make sure new courses set the timecreated field

Added per-course config and use of a word for "student"

Removed check for course format changing

Changes to support new logging format

Fixed up use of isteacher (removed isadmin check because it's done in isteacher now)

Allow admin to do anything the teacher can do

moodle

Initial revision