Log of /moodle/course/edit_form.php

course-edit MDL-20204 Fixed recent regression get_list_of_themes returns array of themes now not strings

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

files MDL-20601 Conversion of many of the uses of print_textarea, and the mforms htmleditor to the new editor
Please forgive me if I have missed converting any output statements. If you do find an output statement that is not formatting correctly please refere to the table I added to this bug in regards to how it should be formatted.

MDL-15262 Added a two capabilities to prevent certain users from changing a course's fullname and shortname. merged from MOODLE_19_STABLE

MDL-15262 Applied patch

MDL-20353 adding missing data types of hidden form fields

MDL-20353 adding missing data types of hidden form fields

MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions

course settings: MDL-18595: Fix regression caused by switching the course settings form to use the new date selector.

The bad commit was http://cvs.moodle.org/moodle/course/edit_form.php?r1=1.65&r2=1.66

Sorry everyone who was inconvenienced by this.

course settings: use the optional option on date selectors, rather than a manua disabled checkbox. Also use new duration element.

MDL-12846 course defaults - grrr I forgot to re-add the original setDefault()

MDL-12846 course defaults - don't apply coursedefaults->category anymore. Backported from HEAD

MDL-12846 don't apply coursedefaults->category anymore.

MDL-17074 course settings - new defaults to be applied on interactive course creation

course settings: MDL-17501 check for moodle/course:visibility in the course settings form.

1. If a user does not have that capability, don't let them change whether the course is visible.
2. Give teachers that capability by default.
3. To avoid regressions, on upgrade, give moodle/course:visibility to any role that has moodle/course:update.

course settings: MDL-17501 check for moodle/course:visibility in the course settings form.

1. If a user does not have that capability, don't let them change whether the course is visible.
2. Give teachers that capability by default.
3. To avoid regressions, on upgrade, give moodle/course:visibility to any role that has moodle/course:update.

MDL-15785 new options for enforcing of  enrolment key commplexity and requirements; backported from HEAD

MDL-15785 new options for enforcing of  enrolment key commplexity and requirements

course categories: Fix many bugs with category editing and permissions. Clean up code.

Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

Merged from MOODLE_19_STABLE.

course categories: Fix many bugs with category editing and permissions. Clean up code.

Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

MDL-15262 fixing previous incorrect merging

cleanup: MDL-17083 Remove the old teacher, teachers, student and students columns from the course table.

For something that has been deprecated for over two years, they were still used in a lot of places!

course settings: MDL-16327 when creating a course, the role renames were not saved.

course settings: MDL-16327 when creating a course, the role renames were not saved.

MDL-16839 forms:  workaround for problematic hard frozen values; merged from MOODLE_19_STABLE

MDL-16839 forms:  workaround for problematic hard frozen values

MDL-15262 Merging from MOODLE_19_STABLE

MDL-15262 using hardFreeze instead of static, because we need this info to b returned from form; the new change* caps are not in effect when adding new courses - merged from MOODLE_19_STABLE + fixed regression in coursename/shortname automatic numbering

MDL-15262 using hardFreeze instead of static, because we need this info to b returned from form; the new change* caps are not in effect when adding new courses

MDL-15262 Instead of removing these form fields entirely, rendering them as static form elements. Merging from MOODLE_19_STABLE

MDL-15262 Instead of removing these form fields entirely, rendering them as static form elements

MDL-15262 Added 3 new capabilities without changing defaults, as suggested by Matt. Merged from MOODLE_19_STABLE

MDL-15262 Added 3 new capabilities without changing defaults, as suggested by Matt.

MDL-12846: move course default settings into config_plugin table

MDL-16676 All references to the text.html and emoticons.html files need to be updated to point to text2.html and emoticons2.html

MDL-12846: add course default settings page

MDL-15498: Completion system

MDL-14679 removed all instances of get_records_menu()

MDL-14679 datalib conversion completed

MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs

MDL-14738 Merged.   Roles section on course settings is now "Role renaming", with help.

MDL-14738 Roles section on course settings is now "Role renaming", with help.

MDL-13815 - Course summary text is optional and empty by default now

MDL-13815 - Course summary text is optional and empty by default now

MDL-13815 - Course summary text is optional and empty by default now

Respect inherited default enrol method when deciding to display the course cost. MDL-14096 ; merged from 19_STABLE

Respect inherited default enrol method when deciding to display the course cost. MDL-14096

MDL-13481, Distinguish between course fullname and user fullname

Merged MDL-13676:  last-minute field change to fix an Oracle problem

MDL-13676  Changed a field so that Oracle can cope with a COALESCE statement.  :-(
           I hate doing this at this late stage, but without it Oracle fails.

           On the way I also fixed the profile page so it displays role aliases if they exist

MDL-13615 course edit settings - improved metacourse compatible detection; merged from MOODLE_19_STABLE

MDL-13615 course edit settings - improved metacourse compatible detection

MDL-12133 validate() method tidying up; merged from MOODLE_19_STABLE

MDL-12133 validate() method tidying up

MDL-11813 - Use existing group setting strings on course edit form so can be
better translated. Patch from Daniel Miksik

Merged from MOODLE_19_STABLE

MDL-11813 - Use existing group setting strings on course edit form so can be
better translated. Patch from Daniel Miksik

merged from MOODLE_19_STABLE

MDL-11813 - Use existing group setting strings on course edit form so can be
better translated. Patch from Daniel Miksik

MDL-10383 - adding UI for new grouping settings into course and mod edit forms + fixed section handling on mod edit page + other minor cleanup

Increasing the displayed size of course->shortinfo to 20. MDL-10026
(bigger but enough smaller than the fullname field)

merged fix for MDL_9804, course shortname limited to 15 chars on forms

fix for MDL-9804, shortname on forms are limited to 15 chars

Move the "default role" into enrolments section  MDL-10511

Tracker #MDL-9353 - Paypal cost of course not visible in course settings.

Tracker #MDL-9353 - Paypal cost of course not visible in course settings.

improved help file - MDL-7073 fix

MDL-9929 we need some other name for password field in course edit page

MDL-9652 rename new password reveal to unmask

MDL-9181 Use new password field with reveal option in editadvanced and enrolment, group and quiz keys

MDL-8537 Added $CFG as the object to check for enrol method when the course is being created.

MDL-8537 Added $CFG as the object to check for enrol method when the course is being created.

fix for MDL-9197. multilang filter is not applied to default role in course settings

fix for MDL-9197, multilang filter is not applied to default role in course settings

Removed conflicts

Complete port of Moodle 1.8 formslib.php back into 1.7 to aid development of any modules that may use formslib in 1.7

MDL-9159

fix for MDL-8966, customizable role names

some small changes

fixes for 'Choose legend/header text carefully - short and non-repeated' MDL-7780

moved set_defaults to main script out of definition method.

* Added setAdvanced functionality see http://docs.moodle.org/en/Development:lib/formslib.php_setAdvanced
* Added MoodleQuickForm method closeHeaderBefore($elementName); http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#Use_Fieldsets_to_group_Form_Elements
* Added moodleform method add_action_buttons(); see http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#add_action_buttons.28.24cancel_.3D_true.2C_.24revert_.3D_true.2C_.24submitlabel.3Dnull.29.3B
* is_cancelled method added to moodleform http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page
* added hidden labels to elements within groups such as the date_selector select boxes and other elements in 'groups'
* quiz/mod.html migrated to formslib
* glossary/edit.html migrated to formslib
* extended registerNoSubmitButton() functionality to automatically add js to onclick to bypass client side js input validation.
* added no_submit_button_pressed() function that can be used in a similar way to is_cancelled() as a test in the main script to see if some button in the page has been pressed that is a submit button that is used for some dynamic functionality within the form and not to submit the data for the whole form.
* added new condition for disabledIf which allows to disable another form element if no options are selected from within a select element.
* added default 'action' for moodleform  - strip_querystring(qualified_me()) http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page

MDL-7401 Course format database/backup/lang/stylesheet/capability support

fixed addStopFieldsetElements of submitbutton

some fixes for disabledIf and using disabledIf in course/edit_form.php

MDL-6949 fixed enrolment choice in course edit form

coding style fixes MDL-6949

fixed metacourse issues in course/edit2.php MDL-6949

migrated mod/forum/post.php to formslib and fixed a string in course/edit_form.php

fix for :
$this->_form->getElement('allowedmods')->
                        updateAttributes(array('disabled' => 'disabled')) ;
 that didn't work in PHP 4. (calling a method on a returned object)

added new dummy function to moodleform to allow some defintion to be done for the form dependent on data values.

Fixed a bug with client side validation of form fields.

Added some default error messages for rules specified in lang pack as err_{rulename} Use the default by setting the rule message to null.

refactored course/edit2.php and edit_form MDL-6914 ; set $CFG->use_new_forms=1; in config.php if you want to test it ;-)

*** empty log message ***

changed $default to $toform - more meaningful

moved setting of defaults from edit2.php to edit_form.php

fix for bug that value of restrictmodules field wasn't available which breaks disabling of allowedmods multiple select

added 2 new methods to form class data_submitted and setDefault

Fixed bug in id generation

changes to html structure for rendering of forms in line with http://moodle.org/mod/forum/discuss.php?d=54907#250816

modifications made to demo new security features

modified api to create an htmleditor element

changed some assignments to assignment by reference when instantiating objects.

* added error message for setHelpButton method not existing
* modified htmleditor class so that differences in formatting for this element are defined by css but use the same html
* added type name of element classes to css wrapper class names

This is a demo of the experimental formslib. It is used here to print and process the course settings form.