Log of /moodle/lib/grade/grade_item.php

grader report MDL-21367 when an item is unhidden its category should unhide to

grader report MDL-21367 when an item is unhidden its category should unhide to

grader report MDL-19704 Added ability to hide course and category totals without hiding anything else

MDL-21191 Fixing another regression in dependency calculation

This is not easy to spot as $params may just contain one more item than $sql
would expect. However, $sql and $params should be well paired.

MDL-21190 Re-fixing a regression in dependency calculation

Sorry for the last commit. This should be the proper way. The problem
was with the question mark within quotes - it was not considered as a
placeholder.

MDL-21190 Fixing a regression in dependency calculation

Grade item: MDL-21161 timemodified never gets set on calculated gradebook columns

Grade item: MDL-21161 timemodified never gets set on calculated gradebook columns

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

MDL-19407 Defaulting all grade items to non-extra-credit when moving to a SWM category, except if they originally come from a SWM category and were set as extra credit there.  Merged from MOODLE_19_STABLE

MDL-19407 Defaulting all grade items to non-extra-credit when moving to a SWM category, except if they originally come from a SWM category and were set as extra credit there.

MDL-18927 fixed performance regression

MDL-18927 fixed performance regression

MDL-18083 MDL-12380 MDL-15680 MDL-16913
Combining grade item and category forms into one, implementing grades over 100%, and patches for correct aggregation.

MDL-18083 Committing gradebook improvements to head

MDL-18402 Merged from MOODLE_19_STABLE

MDL-18402 Reverting aggregationcoef default

MDL-18402 Setting aggregationcoef to 1 if left empty

MDL-16785 bogus grades inserted when formulas used - credit Michael Spall and Ann Adamcik; merged from MOODLE_19_STABLE

MDL-16785 bogus grades inserted when formulas used - credit Michael Spall and Ann Adamcik

MDL-15680 Committing the small refactorings required for the implementation of the weights interface

MDL-15680 Added grade category aggregation settings and weights, plus correct handling of 3 types of weights.

MDL-14679 finished gradelib conversion

MDL-14967 More upgrades

MDL-14967 Upgraded gradebook code and unit tests. 4 failing tests in grade_item to fix.

"MDL-14129, fix print_error"

MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs

MDL-14129, remove all the other error() call

MDL-14065 Fixed gradebook unit tests, including a bug fix in grade_item class.

Commented out buggy backuplib tests, and replaced E_ALL with DEBUG_DEVELOPER in dmllib tests

Backporting from HEAD

MDL-14065 Fixed gradebook unit tests, including a bug fix in grade_item class

MDL-13899 improved submission and grading date hack; merged from MOODLE_19_STABLE

MDL-13899 improved submission and grading date hack

MDL-13899 feedback itself is a type of grading - date graded is now affected by feedback too; merged from MOODLE_19_STABLE

MDL-13899 feedback itself is a type of grading - date graded is now affected by feedback too

MDL-13943 improved perf when sending multiple grades into grade_update(); merged from MOODLE_19_STABLE

MDL-13943 improved perf when sending multiple grades into grade_update()

MDL-13920 assignment without grades now sets text grade type, fixed overriding of feedback and overriding logic in general on grade edit page; merged from MOODLE_19_STABLE

MDL-13920 assignment without grades now sets text grade type, fixed overriding of feedback and overriding logic in general on grade edit page

MDL-13845 rewritten rounding in grades classes again - rounding done also before storage into db so that we can compare the values properly and skip db updates if possible + some more optimisations; merged from MOODLE_19_STABLE

MDL-13845 rewritten rounding in grades classes again - rounding done also before storage into db so that we can compare the values properly and skip db updates if possible + some more optimisations

MDL-13863 detect missing idnumbers in formulas after restore; merged from MOODLE_19_STABLE

MDL-13863 detect missing idnumbers in formulas after restore

MDL-13850 fix automatic creation of course grade item; merge dfrom MOODLE_19_STABLE

MDL-13850 fix automatic creation of course grade item

MDL-13845 major performance problems when regrading course; merged from MOODLE_19_STABLE

MDL-13845 major performance problems when regrading course

MDL-13730 site setting for aggregation of scales; merged from MOODLE_19_STABLE

MDL-13730 site setting for aggregation of scales

MDL-13695 precreating grades in grade calculation if needed; merged from MOODLE_19_STABLE

MDL-13695 precreating grades in grade calculation if needed

MDL-13269 fixed regrading of activity raw grades; merged from MOODLE_19_STABLE

MDL-13269 fixed regrading of activity raw grades

MDL-12518 fixed restore of grade calculations; merged from MOODLE_19_STABLE

MDL-12518 fixed restore of grade calculations

MDL-12900 prevent fatal errors when incorrect scale id specified in grade_item; mergedfrom MOODLE_19_STABLE

MDL-12900 prevent fatal errors when incorrect scale id specified in grade_item

Merging from 1.9

Backporting small changes from Head

MDL-12517 - Move checking code into the user interface layer where it belongs. Merged from MOODLE_19_STABLE.

MDL-12517 - Move checking code into the user interface layer where it belongs.

MDL-12517, notify when grades entered into gradebook is out of bounds

MDL-12517, notify when grades entered into gradebook is out of bounds

MDL-7028 gradebook related changes for course reset; merged from MOODLE_19_STABLE

MDL-7028 gradebook related changes for course reset

MDL-12182 Reverting to pre-upgrade in order to prepare a patch instead

MDL-12182 Only testgradeitem.php isn't yet completed.

MDL-12154 used proper cast to float before !== comparison merged from MOODLE_19_STABLE

MDL-12154 used proper cast to float before !== comparison

MFC: MDL-12154 used proper cast to float before !== comparison

MDL-12154 used proper cast to float before !== comparison

Restoring some of the static calls which were converted unnecessarily

More fine-tuning of gradebook classes

Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object).

Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object).

MFC: MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS

MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS

MFC: MDL-11973 Improved showing of hidden items in ouuser and user report

MDL-11973 Improved showing of hidden items in ouuser and user report

fixing previous merge

MFC: MDL-11957 improving and cleanup in grade overriding

MDL-11957 improving and cleanup in grade overriding

Fixing unit test failures

merged fix for MDL-11902, gradebook formula dereferencing problem

proper copy and format, sorry

fixing previous commit

adding back

bad merge, removing first then adding again

MDL-11902, gradebook formula dereferencing problem

MFC: MDL-11278 improved forced category settings - refactoring + regrading forced + new setting to hide forced settings in UI

MDL-11278 improved forced category settings - refactoring + regrading forced + new setting to hide forced settings in UI

MFC: MDL-11718 aggregated grades which depend on hidden grades are now hidden too + cleanup in grader report

MDL-11718 aggregated grades which depend on hidden grades are now hidden too + cleanup in grader report

MDL-11432 eliminated majority of RecordCount uses, added several missing rs_close() - this should help improve perf on some platforms - Eloy says ;-)

Updated copyright notice in header

MDL-11578 ,  MDL-11578 , MDL-11573 :
* renamed Preferences to "My report preferences"
* renamed Site defaults to "Report defaults"
* rename Change site defaults to "Change report defaults"
* reintroduced Inherit option to Grader preferences - Nicolas was right, it is not possible to implement preference overrides without it with our current get_pref inplementation
* new separate option in plugin selector "Course settings"
* moved displaytype, decimals and aggregation position to "Course settings"
* created new table grade_settings + related functions grade_get/set_preference()
* user report now uses grade_seq class instead of grade_item::fetch_all(); added preloading of grade items into grade_grade instances
* other minor bugfixing/cleanup/improvements

Please note that the Grader report preferences and its defaults must be resaved again - sorry.

MDL-11618 removed the inherit override from decimals and gradetype used on grader report preferences + several bug fixes + settings improvements

MDL-11576 grader report - if user can not see hidden grades they are treated as NULLs and column totals

MDL-11576 Added the groupsql clause to has_hidden_grades

MDL-11576 New grade_item method has_hidden_grades(), which returns a simple count of hidden grades for the item.

MDL-11495 removed GRADE_DECIMALS_DEFAULT null constant, is_null() used instead for tests, -1 used in menu options

MDL-11480 Reviewed, tested, and pplied Petr's patch.

Fixing OU report issues

MDL-11433 Implemented grade_items.decimals instead of user preference in grader report.

MDL-11417 usermodified now stored properly in grade_grades table when update_(raw|final)_grade() used

overridden flag is now used to track the last time of modification - going to use it in assignments to print the correct time/date

MDL-11363 fixing defaults of new optional fields of grade classes - now properly applied when creating new instances too

MDL-11363 merged tables grade_grades with grade_grades_text - it is now possible to define fields as required and optional
finally fixed formula validation in calculation edit form

MDL-11357 removed _grade_updated() from activities and grade_item class

MDL-11356, set display of grade items to database default (-1)

MDL-11353 Completed the implementation. This included a new method in grade_item: get_displaytype(), since that value could be set to default, and we must then look up to course, then site values. And the get_letter() method in grade_grade has been modified to first check the grade_letters table. All works like a dream!

MDL-11312 Added new grade_letters table, and new grade_items.display field.

MDL-11278 Implementation is complete, but grade_categories records in DB are not affected by global settings. This way, when global settings are switched back to "Do not Force", the original category settings will be in place.

MDL-11130 added aggregation inside all subcategories + added graded/all aggregation option

MDL-11092 events are not used for changed raw grades anymore + minor cleanup in handling of raw grades (now used only for modules or other external plugins that produce grades)

MDL-10829 Added get_grade_item() to the grade_item class, for cases when we don't whether an object is a category or a grade_item. The new interface for viewing and adding idnumbers (no editing) is 99% finished. Help strings still to do.

MDL-10829 Added get_idnumber() for both category and item classes

MDL-10109 fixed aggregate outcomes depends_on() incorrect condition

improved hiding support in grade/

final locking API cleanup

various locking improvements and fixes, cron locktime support stilll missing

removing $grade_item param from grade_grde methods - not needed anymore, assignment to grade_item property used instead
fixed typo in grade refresh code

fixes for overriding of scales, outcomes and minor access control tweak

Fixed names of total columns

MDL-10223 module grades are now refreshed after unlocking

MDL-10109 optional aggregation of outcomes together with grades

MDL-10711 adding deleting of grade data when deleting module or course

improved aggregation - items without value (none + text) are not aggregated; faster regrading of categroies with no grades; lang typo fixed

MDL-10549 outcomes quickgrading in assignment
TODO: fix html and CSS

MDL-10105 some more idnumber fixes

MDL-10364 improved calculation form

outcome related fixes

MDL-10544  basic support for outcomes grading in modules - implemented in assignment popup grading (TODO: fix html and css there)

MDL-10636 reverting last commit

MDL-10636
Attempting to fix a number of bugs related to backup/restore for gradebook

MDL-10557, adding format_string prior to return of grade item name in order to support multilang filger

added proper rs_close($rs)

MDL-10563 item excluding implemented;
improved/fixed grade edit page;
some other improvements and cleanup

MDL-10364 improved internal formula format

MDL-10524 fixed aggregation for course item + other minor improvements

MDL-10525 renaming class grade_grades and grade_grades_text - singulars for all grade class names

MDL-9137 added new aggregation needed for upgrade - weighted + extra credit
minor item edit form cleanup
fixed minor bug in grader/lib.php

MDL-10478 Added category preference aggregationview. This one is linked with the more global preferences and $CFG. However, a category-specific preference needs implementing: grade_report_categorystate{$catid}, which equals GRADE_CATEGORY_EXPANDED or GRADE_CATEGORY_CONTRACTED. I've written a stub in grade/report/grader/lib.php around line 492 for pruning out the grade_tree according to these prefs.

We'll also need to implement the actions for the -/+ icons.

MDL-10345 Fixed bug that changed a null scale finalgrade to 1 due to passing through bounded_number(1, null, 3)

MDL-10111 aggragationcof for weighted categories and extra items in old gradebook

use min max bounds in update_final_grade()

major grade editing fixes and improvements - grader form now knows if grade is editable; fixed broken quickgrading; feedback format is handled the same way as in the rest of moodle - automatically converted to FORMAT_HTML when editor enabled; fixed calculation of grades that was breaking locking

MDL-10437 moved editing forms to grade/edit/ directory - these should be shared by all reports, there were too many files in grader directory anyway

MDL-10364 calcualtion validation improvements

MDL-10364 calcualtion validation improvements

grade edit form, and adding set_locktime for grade_grades and grade_item

MDL-9628 Enabling multiple feedback and grades update. Feedbacks now working, but grades don't (at least scales don't)

fixed notice in update_raw_grade

fixed notice in update_final_grade

MDL-9137 new grade_grades field overridden; item edit form fixes; other minor fixes and improvements

MDL-10364 fixed de/normalization of calculation formulas in item edit form

fixed default needsupdate property

MDL-10226 fixed breakage in grade computing

MDL-10226 improved regrading of final grades - optimised db access, partial regrading when raw grade updated

MDL-10365 Improved handling of history when inserting/updating/deleting in new grade reports;first part

complete unit tests for grade_item + minor cleanup in insert and update

More language strings, minor edits.

complete unit tests for grade_category, minor API cleanup, fixed forced regrading in grade_category

MDL-10224 fixing some more regressions in grade reports; adding proper CSS; more fixes and improvements

MDL-9629 fixed regressions in grade reports caused by my previous commits, added unfinished forms for category and item edit

MDL-10224 some more improvements in grader report related to total course grade and category grade + other bugfixes

MDL-10224 finishing the commit, grrr

MDL-10224 total course grade implemented + lots of other changes and improvements; there are still some regressions and bugs - going to fix them ASAP; some unit tests still missing too

Changed grade_item so that its grademax is count(scale_items) and grademin is 1, to be consistent with use of scales throughout Moodle.

MDL-10251 finished hiding implementation for grades, items and categories + unit tests

fixed locking problem in update_raw_grade()

moving event trigger from update_grade() to grade_item->update_raw_grade(); removing itemnumber generation for now

MDL-10233 improved static factory methods of grade obejcts fetch() and fetch_all(); implemented default values of grade objects, fixed null values for some properties that are not required - unit tests included, tested with PHP4 and PHP5

MDL-10231 merge grade_calculations and grade_items table + calculation improvements
MDL-10233 fixed grade_*::fetch() - does not modify $this anymore, we can now use it from normal methods to fetch other objects of the same class.

MDL-10226 regrading of final grades improved, calculation cleanup before MDL-10231

MDL-10223 Implement locking of grades and grade items - cron support still not implemented;
this patch also contains improvements in handling of needsupdate, though it is not yet fully working for calculated grades

MDL-10202 merge raw and final grade tables

MDL-9137 calculated grades should work now, some other minor cleanup

MDL-9137 removing obsoleted function, finals now processed only by update_final_grade()

MDL-9137 various grading improvements
1/ initial support for migration of old grade_items and categories (not tested)
2/ rewritten grade update and calculation logic
3/ initial support for calculation formulas
4/ minor API refactoring and cleanup
5/ various small bugfixes
6/ fixed use of grademax with scales
7/ fixed some unit tests

TODO:
* implement proper locking of grades - needs discussion
* force recalculation of all formulas after adding/removing/changing of grade items
* better delete flag support
* support for NULLs n backup - Eloy already proposed a solution
* support for NULLs in set_field()
* speedup
* more unit tests nd functional tests

grade_item idnumber now self generated if needed.
deleted flag implemented in grade_item::update method
added GRADE_TYPE_NONE to gradelib and updated grade_item object
Implemented multiple items (generation of itemnumber when not explicitly given)

fixing uninitilaized scale problems in last commit

MDL-9516 new central grading function update_grade(); to be improved/tested more tomorrow

MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib)

MDL-9137 Removed hidden field from grade_categories and added deleted field to grade_items. Also added 2 images in pix/i

MDL-9629 Category edit page now implements delete, show/hide, lock/unlock, moveup/movedown and move actions. The edit icon is also shown but not yet implemented.

MDL-9628 Move work on the category edit page

MDL-9506 MDL-9137 MDL-9629
Added a number of small getters and setters to grade_item and grade_category, to hide the structural differences between the two, and provide a common interface for cases when we are not sure whether an $object is of one type or another.
The grade_tree::renumber() method now adds complete objects to the need_update array, because both grade_category and grade_item need to update their parent field when moved to a different parent. Amazingly, these important changes worked straight away (after 1 hour of coding without testing anything), and all the unit tests passed!

MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.

MDL-9506 Corrected a number of small errors in unit tests and classes.

MDL-9506 WOrking on grade_tree edit tree

MDL-9629 Beginning the edit category page. Also added dmllib::sql_max($field) and fixed a few bugs. Grade_item should now extrapolate its sortorder upon insertion if not set, by looking up the last sortorder in the table, and incrementing by 1.

MDL-9506 Added grademax extrapolation from scale info for grade_item, in insert() and update() methods. Corrected a few other minor bugs.

MDL-9889 Fixed a couple of bugs that were only detected by PHP5. Nothing major at all.

MDL-9506 Removed the debugging message for the fetch() methods. Added droplow and keephigh rules to grade_category::aggregate_grades(). The only question now is what to do when the droplow or keephigh field is larger than the number of grades for a given user/item combination. At the moment it just gives that value 0.

MDL-9506 New grade_category::set_as_parent($children) method (non-static). Crucial method for adding categories over children. 4 constraints have been set up, and successfully tested in unit tests. However, the method fails when it comes to updating the children's parent fields. The test data may be missing some required fields.

MDL-9506 Elements of the array returned by grade_category::get_children are now indexed by sortorder, to work more easily with grade_tree methods.
New get_sortorder method for grade_category and grade_item. This is used when the type of an object is unknown, and could be either one. Because categories have a "virtual" sortorder (through their grade_item), they can transparently return one as well.
Unit tests fail for grade_tree at present because of faulty implementation which is being fixed. The $depth attribute has been completely removed, as well as a number of switch statements, in favour of an $index variable which is exploded and used to build strings of array keys for eval statements (unset and array_splice). Can't wait to get all this working :-)

MDL-9506 Added some unit tests, found some errors, and realised they came from incorrect setup unit test data, which I corrected (grade finals for item 3 were set to 2-digit ints although item 3 was a scale of 1-7.

MDL-9506 Finally cracked the category aggregation. However, more thorough unit tests need to be written, with exact expectations instead of ranges, as currently used. All unit tests pass.

MDL-9506 Almost completed category aggregation, including generation of raw and final grades held by these categories. Only a few small glitches remain, that cause these grades not to be generated properly. This is the last critical element of the gradebook API, so I'm looking forward to finishing it :-)

MDL-9506 Finished implementing the propagation of needsupdate flag up the hierarchy when a lower element justifies it. All unit tests pass. The next task is to implement the generation of raw grades and final grades based on this needsupdate setting.

Removed set_timecreated and just tidied up some time-related things

MDL-9506 small fix

MDL-9506
grade_grades_raw
    added grade_item object
    added load_grade_item()
    added call to grade_item->flag_for_update() when object is inserted, deleted or updated
grade_grades_final
    added grade_item object
    added load_grade_item()
grade_grades_text
    added grade_item object
    added load_grade_item()
grade_item
    added qualifies_for_update()
    added call to grade_category->flag_for_update() when object is inserted, deleted or updated (only when qualifies_for_update() is true)

However since I have made this last set of changes, the unit tests are performing extremely slow, and several of them fail. I suspect that there is a serious performance issue involved in using objects too heavily, instead of performing more SQL queries, especially when updates are concerned. Often a complete object is SELECTed before it is amended in an object form then UPDATEd.

In the next iteration I will look at this seriously, and put together some tests with thousands of users and many grade_items, to see how well the API responds.

MDL-9506
grade_category:
    new parent_category object
    new load_parent_category() method
    new flag_for_update() recursive method
grade_item:
    new category object
    changed get_category() to load_category() and updated testgradeitem
    added missing idnumber field
    new flag_for_update() recursive method

MDL-9506 Unit test tables are now created and emptied using XMLDB. raw.gradescale and final.gradescale have been removed in favour of a single gradevalue. Scale value is no longer rounded until moment of display. A number of other changes which you can look at by browsing the diff :-)

MDL-9506 Stuck on grade_category->generate_grades. I cannot figure out how to recursively generate raw grades for each category's associated grade_item based on that category's children categories and items. Heaps of other changes with this commit, including a new grade_object::update_from_db() method, which uses the state of the record in DB to update the current object with a matching id (useful when you insert an incomplete object in the DB and want to get the default values as set up in the DB).

MDL-9506 Issue 1: adjusting a gradeitem's value would result in a grade_final object with gradevalue assigned, even when a gradescale should have been assigned. Issue 2: double grade_final entries when calling grade_item->load_final() after grade_item->generate_final(). Issue 3: Calling grade_item->update_final_grade() without first calling grade_item->generate_final() would result in fatal error. generate_final() is now called if the raw and final arrays' sizes don't match.

MDL-9506 Removed implicit loading of associated objects from constructors (grade_item and grade_grades_raw) to avoid very large numbers of sql queries when only little data is required. The load_scale() method, for example, needs to be called explicitly.

MDL-9506 Fixed some small issues.

MDL-9506 See previous revision. This adds same functionality but in relation to the hidden field.

MDL-9506 Added grade_item::toggle_locking and unit tests. Affects all final grades if reqested.

MDL-9506 Upgraded grade_item::adjust_grade with Darlene's more elegant formula. Completed grade_category::get_children($depth, $arraytype). Added 4 constants to help that method. Added and passed all unit tests (111 now).

MDL-9506 Finished all unit test stubs, another batch to write soon. One one test fails because I haven't implemented recursive category hierarchy output yet, and not sure if it's needed. A grade_category already returns its immediate children, and that may be enough.

MDL-9506 Finished grade_item::adjust_grade, which now also adjusts scale grades correctly. Added grade_scale object to wrap around the current non-normalized scale DB table. When/if we upgrade to grade_scales and grade_scale_items DB tables, changing the grade_scale class will be easy.

MDL-9506 Implemented rescaling and grade adjustment formulas in grade_item::adjust_grade(). Also wrote unit tests.

MDL-9506 Lots more unit tests, and work on grade_item::update method and associated functionality. 3 unit tests currently fail, so more work needed.

MLD-9506 Corrected update_final_grades() in grade_item, which was updating the grade_raw table
instead of grade_final. Made a few other adjustments.

MDL-9506 Removed redundant portion of code.

MDL-9506 Added grade_grades_raw as a proper object used by grade_item. Also added a global function in gradelib for updating grade_grades_raw objects.

MDL-9506 Implemented get_raw and get_final, plus added method_exists() checks for each unit test.

MDL-9506 Number of important changes, restored unit test stability, on to next changes...

MDL-9506 Renamed lib/gradebook to lib/grade (bug MDL-9506)