Log of /moodle/lib/grade/grade_object.php

weekly cvs snapshot

weekly git snapshot

weekly git snapshot

MDL-24321 switching to stdClass in /lib/

MDL-24276 "static abstract" combination is deprecated since PHP 5.2, replacing with our coding_style exception

fixed phpdocs and marked methods as static

gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change pt 2

gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change pt 2

gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change

gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change

MDL-21249 improved php docs and adding direct access prevention in editors

fixed silly comment typos

MDL-21790 fixed dml conversion regression - credit goes to Evan Irving-Pease for the patch and discovery, thanks

grader report MDL-19704 Added ability to hide course and category totals without hiding anything else

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

MDL-18293 $DB->something is using exceptions, no need for ifs there, removing useless strings

MDL-15498: Completion system

MDL-15189 magic quotes finally removed

MDL-15094 some forgotten conversions

MDL-14967 DB upgrades. Not finished yet.

MDL-15085
String points to correct module now

MDL-14679 finished gradelib conversion

MDL-14967 More upgrades

MDL-14967 Upgraded gradebook code and unit tests. 4 failing tests in grade_item to fix.

"MDL-14129, fix print_error"

MDL-14129, remove all the other error() call

MDL-12182 Reverting to pre-upgrade in order to prepare a patch instead

Restoring some of the static calls which were converted unnecessarily

Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object).

Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object).

MFC: MDL-10365 grade history can be turned off + lifetime

MDL-10365 grade history can be turned off + lifetime

Unit test refactoring using mock objects. NOT FINISHED: testgradecategory and testgradeitem are incomplete. The other tests work great however, and no longer a need for DB data

MFC: MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS

MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS

MFC: MDL-11278 improved forced category settings - refactoring + regrading forced + new setting to hide forced settings in UI

MDL-11278 improved forced category settings - refactoring + regrading forced + new setting to hide forced settings in UI

Small unit test-related fix

Minor changes related to unit testing

Updated copyright notice in header

MDL-11363 minor doc improvement

MDL-11363 fixing defaults of new optional fields of grade classes - now properly applied when creating new instances too

MDL-11363 merged tables grade_grades with grade_grades_text - it is now possible to define fields as required and optional
finally fixed formula validation in calculation edit form

MDL-10636 reverting last commit

MDL-10636
Attempting to fix a number of bugs related to backup/restore for gradebook

Optimising the grader report

MDL-10365 Improved handling of history when inserting/updating/deleting in new grade reports;first part

MDL-9268
Added language strings for grade item edit form.
Fixed HTML error in grader report.
Added tabs to category edit page.

MDL-10224 total course grade implemented + lots of other changes and improvements; there are still some regressions and bugs - going to fix them ASAP; some unit tests still missing too

MDL-10233 improved static factory methods of grade obejcts fetch() and fetch_all(); implemented default values of grade objects, fixed null values for some properties that are not required - unit tests included, tested with PHP4 and PHP5

trailing whitespace cleanup in new grade libraries

MDL-10103 grade_object:insert() now fetches the fresh data from db and updates itself; update_from_db() now uses the same process as new grade_object() for consistency

grade_item idnumber now self generated if needed.
deleted flag implemented in grade_item::update method
added GRADE_TYPE_NONE to gradelib and updated grade_item object
Implemented multiple items (generation of itemnumber when not explicitly given)

MDL-9317 Applying Petr's second patch

apply magic quotes before using var in sql query in fetch_all_using_this()

MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected.

MDL-9506 Corrected a number of small errors in unit tests and classes.

MDL-9506 Removed the debugging message for the fetch() methods. Added droplow and keephigh rules to grade_category::aggregate_grades(). The only question now is what to do when the droplow or keephigh field is larger than the number of grades for a given user/item combination. At the moment it just gives that value 0.

MDL-9506 Elements of the array returned by grade_category::get_children are now indexed by sortorder, to work more easily with grade_tree methods.
New get_sortorder method for grade_category and grade_item. This is used when the type of an object is unknown, and could be either one. Because categories have a "virtual" sortorder (through their grade_item), they can transparently return one as well.
Unit tests fail for grade_tree at present because of faulty implementation which is being fixed. The $depth attribute has been completely removed, as well as a number of switch statements, in favour of an $index variable which is exploded and used to build strings of array keys for eval statements (unset and array_splice). Can't wait to get all this working :-)

Removed set_timecreated and just tidied up some time-related things

A few small fixes and clean ups

MDL-9506 Stuck on grade_category->generate_grades. I cannot figure out how to recursively generate raw grades for each category's associated grade_item based on that category's children categories and items. Heaps of other changes with this commit, including a new grade_object::update_from_db() method, which uses the state of the record in DB to update the current object with a matching id (useful when you insert an incomplete object in the DB and want to get the default values as set up in the DB).

MDL-9506 Moved unit tests in a simpletest subfolder so they can be automatically grouped. Added grade_history and grade_text object and another heap of small implementations.

MDL-9506 Finished all unit test stubs, another batch to write soon. One one test fails because I haven't implemented recursive category hierarchy output yet, and not sure if it's needed. A grade_category already returns its immediate children, and that may be enough.

MDL-9506 Number of important changes, restored unit test stability, on to next changes...

MDL-9506 Renamed lib/gradebook to lib/grade (bug MDL-9506)