Log of /moodle/lib/weblib.php

all MDL-20821 Removed more deprecated functions

weblib MDL-19196 Added guard around call to error_get_last to prevent error if running old php

MDL-20693 new NO_DEBUG_DISPLAY define

moodle_url MDL-20674 Added a method to allow the dev to set the anchor attribute of a moodle_url

redirect MDL-20546 Set page type to embedded to avoid ever printing header/blocks/footer on redirects

navigation MDL-20395 Fixed regression created earlier

simpletest-navigation MDL-20395 Fixed up regressions in the simpletest caused by recent changes to upgrades to navigation lib.
Also fixed issue whereby PAGE->set_url was being called by testdeprecatedlib but not being reset to the original value causing several flow on errors through simpletests

unit tests: MDL-20398 spurious exceptions when $CFG->debugdisplay is false

Doh! I had the logic the wrong way round in my previous commit. Sorry.

unit tests: MDL-20398 spurious exceptions when $CFG->debugdisplay is false

core MDL-19791 Replaced deprecated functions, added set_url calls

navigation MDL-20332 MDL-20324 Modifications to fix the following issues:
 * If no active node is found when the navigation is called upon then we attempt to find a best match active node
 * Links are now produced with frame breakout actions
 * Links ending with / are presumed index.php for matching purposes

"MDL-14706, move javascript code to javascript-static.js"

weblib MDL-20276 Reverted fix to deal with relative URLs

questions MDL-20276 Fixed minor issue with URL handling within the paging bar for the question bank

core MDL-19786 Deprecated print_header_simple function - now use PAGE and OUTPUT methods

admin MDL-19799 Upgraded print_header and build_navigation calls to use PAGE and OUTPUT equivilants

navigation MDL-14632 Very significant navigation commit
This patch introduces two new blocks global_navigation_tree and settings_navigation_tree
both of which have been designed to make full use of the new navigation objects available through
the $PAGE object.
Bulk of this code is within lib/navigationlib.php

MDL-19799 Upgraded calls to link_to_popup_window()

MDL-19799 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno

MDL-19799 Upgraded calls to helpbutton, print_simple_box* and notify

MDL-19799 Upgraded calls to choose_from_menu

MDL-19756
* Removed outputpixfinders.php and put that code back in outputlib.php
* Created labelled_html_component class and subclassed all appropriate components from it
* Added component::add_confirm_action($message) as a shortcut for adding a confirmation popup
* Fixed bug in close_window_button()

MDL-19756 Renamed moodle_select to html_select for better API consistency

MDL-19799 Converted print_box* to $OUTPUT->box*

MDL-9644 Added a compare() method to moodle_url

MDL-19799 Converted all print_footer() calls

MDL-19799 Migrated calls to print_heading

MDL-19756 Fixed bugs and improved API in various places

MDL-19756 Deprecated update_course_icon() and implemented a simple $OUTPUT->edit_button($moodleurl) method which uses $USER->editing

MDL-19756 MDL-19825 MDL-19823 MDL-19794 Deprecated update_tag_button, update_categories_search_button and print_user, and updated a few pages that depended on the now deprecated functions

MDL-19756 Deprecated update_mymoodle_icon() and upgraded my/index.php with new output code

MDL-19756 Migrated print_heading_with_help

MDL-19756 Removed debugging message regarding string URLs in redirect() function

MDL-19756 Migrated print_textfield, choose_from_radio and print_checkbox

MDL-19976 Refactored select_menu() into select(), now supporting menu, radio and checkbox rendering. Added radio() and checkbox() functions.

MDL-19756 Migrated print_close_window to $OUTPUT->print_close_window($text)

MDL-19756 Migrated popup_form

MDL-19756 Try to bring some consistency to how we handle & is attribute values.

MDL-19756 Migrated time selectors from weblib to outputlib

MDL-19756 Migrated choose_from_menu_yesno and choose_from_menu_nested into $OUTPUT->select_menu()

MDL-19756 Migrating choose_from_menu to outputlib

MDL-19756 Removing debugging call

MDL-19756 Migrated the following functions from weblib to outputlib:
1. button_to_popup_window
2. link_to_popup_window
3. print_single_button
4. print_spacer
5. print_file_picture (deprecated)
6. print_user_picture
7. print_png (deprecated)
8. helpbutton
9. doclink
10. print_paging_bar
11. notice_yesno

"MDL-19118, comments api"

MDL-19871 new parameter syntax from htmlpurifier 4.0.0

weblib: Let redirect() take a moodle_url object.

MDL-19755 print_table replaced with $OUTPUT->table

rowclass property has been deprecated, rowclasses should be used.
Direct assigning of the class has been deprecated,
moodle_html_elements::set_classes() should be used instead. In both
cases, debugging message is displayed.

themes: MDL-19077 Don't us $OUTPUT in debugging.

upgrade: MDL-19763 Improve the redirect that forces a DB upgrade when there are major changes

Also fix redirect, so 303 redirects don't need to fully initialise $OUTPUT.

weblib MDL-19750 Fixed regression caused by implementing new PAGE methods

themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme

The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)

Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)

The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.

How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.

Further refinement for how the theme and block code gets initialised.

Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)

Things that are still broken:
 * some pages in lesson, quiz and resource. I'm working on it.
 * lots of developer debug notices pointing out things that
   need to be updated.

lib MDL-19739 Moved call to include dropdown.js out of outputlib and into the same body of code in weblib
that uses it.
This ensures that it is only loaded if it is used, which is only is the browser is opera, or IE

themes: MDL-19077 move deprecated function page_id_and_class to deprecatedlib.php

MDL-19716 moodle_url: new parameter to get URL with unescaped ampersands

moodle_url::get_query_string() and moodle_url::out() now accept new
optional parameter. Backwards compatible. This is needed so we can use returned URL
during redirect() which expects unescaped ampersands.

MDL-19689 adding IGNORE_MULTIPLE to get_record - please note this parameter is discouraged

MDL-19696 & MDL-16706 refactor sam's redirect changes, so they can work during initial install.

XHTML strict

MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url

MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url

MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url
and $CFG->modpixpath to $OUTPUT->mod_icon_url

MDL-19690 - eliminate the $OUTPUT->initialise_deprecated_cfg_pixpath horrible hack.

Replace $CFG->pixpath with $OUPTUT->old_icon_url(...) instead.

MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url

MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url

MDL-19690 - 4 more $CFG->pixpath to $OUTPUT->old_icon_url

weblib MDL-16706 Elimate inline scripts, replaced with PAGE methods

themes: MDL-19077 change how the theme is initialised and CSS is served.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

$THEME is now initialised at the same time as $OUTPUT. Old functions like
theme_setup are deprecated in favour of methods on $PAGE. There is a new
theme_config class in outputlib.php that deals with loading the theme config.php file.

CSS used to be served by themes styles.php files calling a function in weblib.php.
Now it works by each theme's styles.php file doing
$themename = basename(dirname(__FILE__));
require_once(dirname(__FILE__) . '/../../theme/styles.php');
which is less code to be copied into each theme. (Old-style styles.php files still
work thanks to some code in deprecatedlib.php.)

Admin UI for choosing a theme cleaned up.

A couple of theme-specific hard-coded hacks like $THEME->cssconstants and
$THEME->CSSEdit have been replaced by a more generic $THEME->customcssoutputfunction
hook. See examples at the end of outputlib.php

Also:
* Fix setting the theme in the URL, which seems to have been broken since 1.9.
* Fix up errors on a few pages caused by the new initialisation order.
* MDL-19097 moodle_page::set_course should not set $COURSE unless it is $PAGE.
* httpsrequired() from moodlelib.php moved to $PAGE->https_required().
* Move has_started() method to the renderer base class.
* Further fixes to display of early errors.
* Remove print_header/footer_old from weblib. I did not mean to commit them before.

"MDL-19077, pixpath is broken, use initialise_deprecated_cfg_pixpath() as a temporary fix"

MDL-19077 - Finish eliminating customcorners-specific code in core.

The custom-corners-specific code now in theme/customcornser/renderers.php
and lib/deprecatedlib.php.

Also, $CFG->pixpath is now causing more problems than ever. If it is
giving your problems, please call $OUTPUT->initialise_deprecated_cfg_pixpath()
as a temporary fix. As you can imagine, we are thinking about a better
long-term fix, which is why that method as a silly, and easy to grep name.

lib MDL-19077 Created output redirect method and implemented against weblib redirect method
This resolves the meta bug that was used when redirecting with a delay
Thanks Tim for the help with this one

MDL-19077 - change how $OUTPUT is initialised.
Please read the comment at the top of bootstrap_renderer in setuplib.php

themes: MDL-19077 new $OUTPUT->header/footer to replace print_header/footer.
Also, part of the change from weblib.php functions to $OUTPUT-> methods.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

This is a big change, and the result is not perfect yet. Expect some debugging output
on some pages.

The main part of these changes are that $OUTPUT->header now looks for a file
in the theme called layout.php, rather than header.html and footer.html. Also
you can have special templates for certain pages like layout-home.php. There is
fallback code for Moodle 1.9 themes, so they still work.

A few of the old arguments to print_header are no longer supported. (You get an
exception if you try to use them.) Sam H will be cleaning those up.

All the weblib functions that have been replaced with $OUTPUT-> have version in
deprecatedlib, so existing code will go on working for the foreseeable future.

MDL-16438 fixed regression during recent plugin centralisation effort

MDL-19580 cleanup of require css and js filepicker code

install: MDL-19610 encapsulate empty($CFG->rolesactive) checks in a during_initial_install() function.

themes: MDL-19077 start implementing moodle_core_renderer
Only a couple of methods implemented. Please review the API and
tell me if you are not happy with the direction I am taking.

MDL-19598: Error in logic that should hide 'skip link' when block doesn't have title

MDL-19566 Refactored some of the more complex regular expressions in their own function and added unit tests for them.

MDL-19418 Replaced ereg* by preg*

MDL-19211, MDL-19544 improved editor embedding, media and dragmath enabled only when moodle configuration and current user permissions allow it to work 100%

MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions

javascript: MDL-16695 print_footer('empty'); I had the wrong type of quotes.
Thanks to Dongsheng for noticing.

javascript: MDL-16695 print_footer('empty'); was not printing the necessary end of page code.

Just some whitespace fixes

MDL-19500 improved editor embedding

MDL-14990 pritning of backtrace does not rely on $CFG any more and can be used from destructors

MDL-14990 implemented query loggin in new native DML drivers

ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.

There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)

breadcrumb MDL-14133 One function missed during fix, got it this time

MDL-19352 maintenance mode reiplemented

MDL-15249 error status codes for exceptions and notices

MDL-15249 more cleanup and refactoring - towards cli upgrade

lib MDL-19236 Added boilerplates and copyrights

MDL-15249 preparation for new cli installer + coding style changes

weblib.php  MDL-19236 added phpdocs and copyrights

MDL-17542 lib/html2text: update to latest upstream version (r2374)
from http://trac.roundcube.net/log/trunk/roundcubemail/program/lib/html2text.php

MDL-19184, MDL-19212 - refactoring, cleanup and improvements in text editors support; localization support is not finished, inline docs incomplete, expect more commits soon

authentication MDL-18273 Custom Authentication Plugin title can be retrieved from specific language file, merged from 19

blocklib: MDL-19010 once again you can add blocks, at least on the coures page.

moodle_page: MDL-12212 remove deprecated calls from course/view.php and page_course::print_header

blocklib: MDL-19010 add block and get_blocks methods

blocklib: MDL-19010 always include blocklib in setup.php, stip includes elsewhere

moodle_page: MDL-12212 reimplement user_is_editing, deprecate isediting

moodle_page: MDL-12212 Kill legacy url_... and blocks_... methods
Start calling $PAGE->set_url in all the places it will be necessary
Start of a stub implementation of $PAGE->blocks to stop other things breaking
Remove some of the special case methods in admin_page

fix remove_params

moodle_page: MDL-12212 ->url and cleanup init of $FULLME, etc.

moodle_url: MDL-12212 clean up moodle_url coding style

moodle_page: MDL-12212 ->docspath

moodle_page: MDL-12212 more ->pagepaths to kill

moodle_page: MDL-12212 ->bodyclasses and initialise_standard_body_classes

moodle_page: MDL-12212 kill $CFG->pagepath (use $PAGE->set_pagetype)
deprecate $PAGE->get_format_name (use $PAGE->pagetype)
deprecate page_id_and_class (use $PAGE->pagetype)

filters: MDL-7336 use $PAGE->context now that it exists

moodle_page: MDL-12212 start of new moodle_page class
* has course and status fields
* $PAGE->status updated by print_header and footer
* $PAGE->set_course now replace course_setup function
* global $PAGE created in setup.php
* unit tests for functionality so far
* Moodle still seems to work after this commit!

MDL-18910 full support for module intro editor with embedded images

MDL-18910 full support for module intro editor with embedded images

MDL-18910 full support for module intro editor with embedded images

MDL-18910 full support for module intro editor with embedded images

MDL-18900 reimplemented trusttext - now using separate db field; the API will be improved and documented together with the new support functions needed for new Editor element

MDL-18901 reimplemented trusstext support in glossary + standardising format column for text fields

"MDL-18486, remove php varible from file picker code, all javascript code goes into a static file"

MDL-18887 using exceptions instead of @ for ignoring of db update/insert failure

filters: MDL-7336 fix upgrade problem when filterall is on. Thanks Nico for finding.

filters: MDL-7336 change weblib to use the new code

* Rename filter base class from filter_base to moodle_text_filter
* Remove unnecessary explicit constructors in moodle_text_filter
subclasses
* New filter_manager class, rather than static methods in filter_base
* Move some logic out of weblib, and into filter_manager
* Count filtering ops when $CFG->perfdebug on, via
performance_measuring_filter_manager
* Kill unused filter_string function. Petr said it should have been
private to weblib

weblib progress_bar: Add a comment and fix some coding style.

weblib: fix bug with disabled pop_form()s

translation: MDL-18766 reverting. I guess it was not yet ready for prime-time.

I'll commit the patch to contrib in case anyone wishes to experiment further.

translation: MDL-18766 Prototype automatic translation system for Moodle.

If Google can do something like http://translate.google.com/, surely we
can do something just as good in Moodle. Here is a first attempt. It is
a bit rough around the edges, and only a couple of target lananguages
have been implemented so far. (More and better attempts welcome!)

In order to ensure that this gets adequate testing, I have made sure that
it gets turn on by default. However, if you really don't like it, you can
turn it off under Administration > Development -> Experimental settings.

help.php: related to MDL-13816. Clean up the URLs used for help files by removing unused parameters.

switch roles: MDL-18132 New Role allow switches page finished.

I also set up a reasonable set of default allows, including setting up some sensible allow_overrides, whatever the rant in MDL-15841 says.

switch roles: MDL-18132 separate database table role_allow_switch instead of re-using role_allow_assign.

This is part 1 that does the back-end:

1. New table role_allow_switch.
2. Upgrade that copies all the allows from role_allow_assign, and then drops the old CFG->allowuserswitchrolestheycantassign.
3. Old function get_assignable_roles_for_switchrole renamed to get_switchable_roles and changed to use the new table. Fixes MDL-18604 in HEAD.
4. Switch callers to use the new function name.
5. Unit tests for this new function.
6. To make those unit tests work, new switch_global_user_id and revert_global_user_id methods in UnitTestCaseUsingDatabase for toggling $USER->id.

I still need to do the editing interface under Administration â–º Users â–º Permissions â–º Define roles. That will be done as a second commit.

weblib: Fix test_format_text_email and unit tests.

gift import: MDL-18390 better way to get the question type name.

weblib: Improve PHPdoc comment and parameter names.

weblib: finish documenting print_user_picture.

weblib: MDL-18224 Create a better mechanism for outputting progress information from batch jobs

MDL-18188 Added a call to the new get_browser_version_classes() function in print_header, so that the classes are always added to the body tag.

weblib: XHTML strict.

MDL-14924 the same title now used on each upgrade/install page (Moodle - 2.0...) + the same footer with moodle logo now used during installation and upgrade - links to admin docs

weblib: MDL-17525 Give previous and next links in paging bars class names, so they can be themed.

Thanks to Daniel Neis for the patch.

I checked the standard theme, and I don't see any rules there that would erroneously apply to these class names in paging bars.

weblib: MDL-14901 Fix misleading comment on print_navigation

theme / navbar: MDL-14133 every link in the nav bar was getting class="first"!

theme / weblib: MDL-14400 Setting $THEME->makenavmenulist = true causes a php notice

MDL-17458 fixed headers used during installation

MDL-17458 upgrade logging implemented + a lot more refactoring + exceptions implemented in install/upgrade code + lang pack cleanup + some more improvements

MDL-381: Added 'Move' button to reduce accidentally moving forum posts.

MDL-17974: Calendar 'new entry' accessibility improvement

MDL-17845 now only one page per installs/upgrade :-D

MDL-17848 oops, yet more cron compatibility fixes for console_write() ;-) I have added a new console_write_error() too

MDL-17848 general support for CLI scripts in weblib; grrr - fixed regression

MDL-17848 general support for CLI scripts in weblib

weblib: improve comment.

MDL-17754, MDL-11061, MDL-9276, MDL-17777, MDL-17787 - various url handling improvemetns; rewritten $FULLME and added $ME, $SCRIPT and $FULLSCRIPT; improved slashargument handling especially for IIS; removed legacy slasharguments functions obsoleted since 1.6; some other refactoring; reverse procy support, ssl appliance support

MDL-17776 added new define CLI_SCRIPT that identifies all CLI scripts + cron (cli scripts do not have session and do not like HTML in output and are executed from command line, cron is an exception)

MDL-16613 refactore session IP tracking; MDL-14213 improved message when IP changes; MDL-17754 SID is regenerated when terminating session and old session is deleted

MDL-17773 new get_login_url() function - fixes missing httpslogin tweaks

MDL-17754 next round of session related refactoring

MDL-17767 loginas refactoring and simplification; full SESSION switching implemented

MDL-17767 loginas internals refactoring - code moved to sessionlib.php

MDL-16613 sesskey cleanup

MDL-17758 fixed hardcoded /admin/ links

MDL-17637 fixed adobe XSS protection

"FILTER/MDL-14582, filters 2.0, compatible with old filters"

MDL-17542 weblib/html2text: replace html2text.php with a GPL alternative (which is also faster)

weblib: MDL-17606 Make the highlight function better, with unit tests.

javascript cleanup: MDL-16583 clean up the close_window function in weblib.php.

MDL-17479 category search: replaced old update capability; merged from MOODLE__STABLE

MDL-17391, change paramters of repository_get_client.

course categories: Fix many bugs with category editing and permissions. Clean up code.

Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

Merged from MOODLE_19_STABLE.

weblib: MDL-16293: background-color attribute stripped from html. Adding 'background-color' attribute to $ALLOWED_PROTOCOLS array so kses doesn't drop it.

MDL-17485 roles: fixed use and definition of review use of moodle/user:viewuseractivitiesreport

MDL-17463 - reparate capabilities for course and admin reports

REPOSITORY/MDL-13766
pass mimetype and return value type to file picker to filter repository instances

Emoticons MDLSITE-564  Patch to avoid [[brackets]] around alt text

MDL-17317 DML: more exceptions - now in connect too

MDL-17331 choose_from_menu(): 'select' selector added always.

MDL-17331 choose_from_menu(): Add 'select' selector too.

MDL-17331 choose_from_menu(): Add "class" optional parameter.

define roles: MDL-16966 etc. polishing the new roles UI following a meeting with Martin.

* Move the show/hide advanced button a bit down the page.
* Improve save button caption when creating a role.
* Don't show defaults on the basic define roles screen.
* Explain the background shading on the advanced roels screen.
* Fix the problem with the risks link to Moodle docs.
* Help icon by the permissions column heading.
* Tables with rotated <th>s, make them vertical-align: bottom.
* Rename explain.php and explainhascapability.php to check.php and explain.php
* Tool tips on the number headers in the explain table.
* Explain table - role names were missing.
* Allow link_to_popup_window to work with full URLs.

quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.

This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.

Let any table have rotated text in its headers. Stolen from sam's activity completion report.

cleanup: MDL-17083 Remove the old teacher, teachers, student and students columns from the course table.

For something that has been deprecated for over two years, they were still used in a lot of places!

role overrides: MDL-17070 Improve override roles page to match the recent usability improvements on the assign page.

Including:
MDL-11529 When assigning/overriding roles, the dropdown for switching to another role should have a number in brackets

MDL-16549 Should not be able to edit the permission associated with moodle/site:doanything on any role.

MDL-17129 dml: implemented exceptions in new drivers, yay!

user selection: MDL-17073 add options to control the search in a collapsible region.

user selection: MDL-17073 add options to control the search in a collapsible region.

weblib: MDL-17085 a function to print a collapsible region of the UI, with the collapsed state stored in a user_perference - I forgot the PHP docs before.

weblib: MDL-17085 a function to print a collapsible region of the UI, with the collapsed state stored in a user_perference.

ajax: MDL-17086 Add a CSS class name to <body> when JavaScript is enabled

ajax: MDL-17084 provide a way for JavaScript to update user preferences.

print_table: allow headings to span multiple columns.

Make developer debug mode available to JavaScript.

MDL-16939 - adding check type exists to avoid PHP notice in build_navigation function; merged from MOODLE_19_STABLE

MDL-15800: clean filelib.php,  fix https image link into the edit profil page (weblib.php), merged from 19

MDL-14696 Option to unenrol user from course when assigned to a role at a higher context; merged from MOODLE_19_STABLE

Fix comment.

MDL-16706 - eliminate miscellaneous inine JavaScript
This does the quiz (apart from the bloody 'secure' window), the question bank and a couple of others.

MDL-16654 Move javascript used by the emoticons help file from javascript.php to javascript-static.js. Fix it so that it actually works.

MDL-16676 Developer debug warning if you refer to the old text.html help file.

MDL-16583 Make require_js accept library names like lib/javascript-static.js without the caller having to fiddle around with $CFG->wwwroot themselves.

MDL-16672 Output a standard set of config variables into JavaScript on every page.

MDL-15810 whitelist _blank target in htmlpurifier cleaning; merged from MOODLE_19_STABLE

MDL-16644 removing striplsahses() and friends

MDL-16637 removing obsoleted spellchecker support

MDL-16628 editortogglebutton removed

MDL-16627 removing obsoleted HTMLArea

MDL-16630 - Change admintree JavaScript to move the code out of the page, and into a separate .js file

Commit the print_js_config, so people can see it as the read http://moodle.org/mod/forum/discuss.php?d=106312

New function to make it easy when you just want to call one JavaScript function, so you don't have to worry about constructing the script tag yourself. I did this in the context of MDL-12391, but I think it is generally userful.

New option on close_window_button to reload the page that opened this pop-up, as the pop-up is closed. Needed in preparation for MDL-16334.

"MDL-14706, comment value check code to make progress bar work"

MDL-16473 Merged style fix for user pics from 1.9

MDL-16410 Implement the delete question type functionality on the question type administration screen.

MDL-16343 Report showing, for a given capability, how it is set in the definition of each role, and everywhere that it is overridden.

MDL-16029 removing recently added support for $extralocation from print_error(), thanks TIm for pointing out this is not the recommended way anymore

MDL-16029 Added $extralocations in the function print_error; merged from MOODLE_19_STABLE

MDL-16292 print_error not backwards compatible with error(get_string('xx', 'moodle')); merged from MOODLE_19_STABLE

Make comment clearer.

MDL-14741: clean up some old code. This needs to be confirmed backward-compatible.

MDL-13766: refactor all libary functions, they now all start with repository_

Curse you CVS!!!  Didn't notice strange merge error.

MDL-16221
The height and width are now included in the user's image.

MDL-16166 centralised enabling of subsystems, fixed some warnings and general cleanup

MDL-13766
1. Use treeview display files in repository
2. Dymanicly loading file support
3. Upload file in local repository plugin
4. Move file picker to the top level of DOM
5. get original photo format from flickr web service

MDL-16036: make the default value in popup_form "selected"

MDL-16002 rewritten upgrade locking and better upgrade progress tracking; MDL-16070 Do not use $a[0] syntax in lang packs + various other upgrade improvements and fixes

Allow font-family "protocol" to avoid kses cleaning it. MDL-15963 ; merged from 19_STABLE

MDL-13766
1. Pass context information to repository
TODO
Not sure about the way to get context, hard to find where we are, because print_textarea and moodle may be used in any place in moodle.
2. Change parameter type in ws.php

MDL-13766, mulit-filepicker in htmleditor worked.

MDL-13766, more changes to mulit-filepicker in one page.

MDL-13766
1. Make mulit-filepicker in one page possible
2. fix lang strings
3. use itemid specify a draft file
TODO
itemid should use a better value.

MDL-14589 initial file storage implementation, temporary file manager, migration of course files; blog conversion MDL-15905; assignment conversion MDL-15904; fromslib  related file improvements MDL-15906

"MDL-13766, move require_once"

MDL-13766
1. Filepicker component for moodleform
2. Integrate TinyMCE and FilePicker
3. Fix show/hide bug in filepicker
4. Rewrite print_login function for ajax

MDL-14741: cleaning up some leftover cruft

MDL-14741: use better names for tinymce-specific javascript functions, add function to trigger the save event of tinymce on form save.

MDL-5018 added thead and tfoot to allowed tags; merged from MOODLE_19_SATLE

MDL-15823 format_string() improvements; merged from MOODLE_19_STABLE

MDL-15813 - correction - add missing 'return'. Again, Jamie, if you see this, please review.

MDL-15820 fixed some install noise on dev sites; merged from MOODLE_19_STABLE

MDL-15813 "return params or a param from moodle_url params and param method when no value is passed to method to set url param(s)."

Methods param and params can now be used in the following ways :

$url->params(); // returns params

$url->params($arrayofnewparams);// add params to url params and then returns all the params.

//--

$url->param('id');//returns value of id param.

$url->param('id', 5); set id param to 5.

MDL-15565, fix bug of maintenance mode alert reminder

MDL-15773 - 'Pass by reference' errors in update from 1.9.1+

MDL-14741: Make tinymce loading simpler, and makes it work on pages with multiple instances.

MDL-15700  Merged from 1.9  Tidied up the maintenance mode display to users

MDL-14741: load editor automatically, from footer/after page is loaded.

MDL-14741: make tinymce toggle editor icon work as it should

MDL-15565, add maintenance mode alert reminder in title and navbar.

Document print_side_block, and eliminate a bit of duplicated code.

MDL-14279: use get_file_url instead of checking $CFG->slashargument manually (merge from 1.9)

MDL-15601 Merged basic checking to avoid some notices

MDL-15413 warn admins if display_errors enabled

MDL-15532 "moving progress_bar class into weblib from adminlib"

MDL-14741: Reverting removal of output buffering.

MDL-14741: Using a better way to include javascript files (removed use of
output buffering) and corrected parameters so that the file manager is
linked to the right course again.

"MDL-15500, change helpbutton debug level to developer, merged from MOODLE_19_STABLE"

MDL-14635 remove tags from glossary block help, merged from 19

MDL-15343 mod upgrade savepoints implemented (the xmldb generator is not updated yet)

MDL-14956 DDL exceptions

MDL-14992 first step towards new database sessions - refactoring of current session code

MDL-15321 - Add a class to the last column and row of the table in print_table to help theming

MDL-15152 reverse MDL-14439 fix for dropdown menu for Opera+Linux, merged from 19

MDL-14898 upgraded html purifier to 3.1.0 in HEAD

MDL-15263 Fixed numeric entities remaining after html_to_text

MDL-15094 fixed print_box() regression

MDL-14956 basic exception support in Moodle + other minor related refactoring

MDL-14905 towards functional DB tests

MDL-14741: Simplifies the activation of the htmleditor. This is a work-in-progress at this stage, but it's an improvement on the current state.

MDL-15189 magic quotes finally removed

MDL-14741 - Make tinymce work with the front page description.
TODO: convert the front page description form so it uses formslib

MDL-14741: use the default html editor, as chosen in the admin settings

MDL-14679 converted some delete_records

MDL-15000 "Moodle url method remove_params doesn't actually remove anything" Fixed.

MDL-14983  add magic quotes stripping option into data_submitted()

MDL-14943 "moodle_url : need way to add extra params when outputting params as hidden fields for forms" added new optional param to method hidden_params_out

MDL-14905 Started on the DDL functional tests. Added an ugly but temporary hack into error() and print_error(), so that they throw an exception instead of dying when UNITTEST is defined.

Installer fixed, prefixes improved, moved conn settings to connect() and some more improvements. MDL-14864

MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs

"MDL-14129, fix print_error"

MDL-14618 HTML class so that link arrows can be themed

MDL-14811 Merged from 1.9:  Fixed the popup window name for HTML editor help

Prevent some notices and process if $CFG->emoticons is not set or empty. MDL-12414 ; merged from 19_STABLE

MDL-12648 Undefined property: stdClass::$wwwroot on popup screen during installation, merged from 19

"MDL-13233, replace the uses of old files to new ones, see tracker"

MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text."
Also fixing the problem in link_to_popup_window function. Test for null instead of empty.

MDL-12864 fix bad XHTML in the messaging popup, merged from 19

MDL-8592: Get spellchecking to work over https (merge from 1.9)

MDL-14439 IE and Opera fire the onchange when ever you move into a dropdwown list with the keyboard - this changes fix the problem. Merged from 19.

MDL-14617 removed PHP4 compatibility string functions

MDL-14617 removed PHP4 compatibility error_get_last()

"MDL-14460, fix get_context_instance, merged from MOODLE_19_STABLE"

MDL-13985 - Fix previous fix to display a warning when whitespace is used in popup window name (merge from 1.9)

MDL-13985 - Prevent popup windows from having a space in their name. (merge from 1.9)

MDL-14497 Fixed several minor bugs in navmenu()

MDL-14476: Made 'fake blocks' in calendar and elsewhere more consistent with real blocks (so styling themes is easier)

MDL-14260: Changed print_heading_with_help so that the help button is outside the heading (for accessibility reasons) and changed themes so that this makes no visual difference.

MDL-14129, remove all the other error() call

MDL-14126 fixed undefined message; merged from MOODLE_19_STABLE

MDL-14126, cron shouldn't print html tags, merged from MOODLE_19_STABLE

MDL-14085, Make print_error() autonomous, merged from MOODLE_19_STABLE

Move error() to deprecatelib.php, merged from MOODLE_19_STABLE

MDL-14103 - remove the call to s() - the string has to already be in html format. (merge - 1.9)

MDL-13985 - removed call to get_string, translation of this string made no sense and broke badly. (merge)

MDL-13880 Overridden and excluded grades are now coloured with alternate row colours that override the default alternate row colours (gray). I also fixed the long-standing notice about aggregationposition. See attached patch.

MDL-13934 - Commit patch by Eloy - prevent display of moodle docs link on redirect pages

MDL-12093 - remove added classes - they don't help the issue and clutter the code

MDL-13886 whitelist text-decoration in kses cleaning; merged from MOODLE_19_STABLE

Clarify unused argument.

Fix the display of the release (merged from 1.9)

MDL-13705

MDL-90 weblib: Introducing mdie() - close sibling of Perl's die()

So that commandline scripts can die with a message and
a nonzero errorcode

MDL-13665 HTML editor is loaded as non-secure on the secure "Add new user" form, patch by Steve Bond; merged from MOOODLE_19_SATBLE

MDL-13661 - fixing incorrect use of array_shift; merged from MOODLE_19_STABLE

MDL-9667 - convert_tree_to_html doesn't set css class properly if
$tab->linkedwhenselected is set

Patch from Jeff Graham

merged from MOODLE_19_STABLE

Fixed $displaypage notice by initialising it

MDL-12538 skip to main does not work if page div contains other attributes; merged from MOODLE_19_STABLE

MDL-13459 Didn't use the patch, which puts its finger in too many pies. Instead just implemented a quick-fix, a temporary get_assignable_for_switchrole() function. It only affects the switchroles menu. Merging from MOODLE_19_STABLE

MDL-13312 fixed notices caused by previous commit, patch by Gary Anderson; merged from MOODLE_19_STABLE

MDL-13310 added static cron cache into format_text() to prevent some db access; merged from MOODLE_19_STABLE

MDL-12945 changing get_fast_modinfo() section property to sectionnum to prevent conflicts with real cm->section; full recent activity speedup when printing user pictures in forum; merged from MOODLE_19_STABLE

Merged from MOODLE_19_STABLE: MDL-13244 - weblib - Add 'summary' attribute to print_table()

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker; merged from MOODLE_19_STABLE

MDL-13154 Make it possible to unit test code that calls error() (2.0 only, PHP5 req)

Merged typo fox for popup windows from 19

added some documentation

MDL-13020 : deprecates make_table

Fix for MDL-9669 : make it possible to specify 0 as cellpadding and cellspacing

whitespace clean up, removed all indentation with tabs and trailing white space

MDL-12906 add an optional parameter $jsconfirmmessage parameter to print_single_button

merged from 1.9 :: MDL-12221 :: removed the "nocoursepage" hack, which was an attempt to find out if a page has a layout-table. I developed this hack because Martin said, that he does not see any chance to implement a layout-table check. This hack followed several exception hacks because Moodel pages are inconsistently created. All those exceptions I could delete too.

Now I added a JavaScript layout-table check which works great.

MDL-12894 Fixing language string mess (language packs containing \n) & moved them to the controllers,
also fixed a few typos and a || instead of && bug.  This all relates to the CLI installer.

Merged from 1.9 and checked :: MDL-12221 :: I added changes to weblib and the forum and glossary view pages, the custom_corners and standard theme to get those pages working.

In the view pages I changed the container function call to a simple "echo 'div ...'" to avoid the custom_corners container overhead and page oddity.

In weblib I added "clearfix" handling to the function "print_box_start($classes ...". "clearfix" is handed over to the containing divs. This is a hack, but I didn't know how to handle it without rewriting too much areas.

New feature: Command line installer.  Credit: Dilan Anurudda.

This was a Google Summer of Code 2007 Project.

This introduces two new files, admin/cliupgrader.php and lib/installlib.php.

It also introduces a new PEAR library, Console_GetOpt.  I have recieved permission from the upstream author to include this in GPL Moodle (essentially dual license it) -  notes in lib/pear.

Most stuff that outputs html during install gets suppressed by the use of a constant.

Run the script like  php admin/cliupgrade.php --help for info.

Note that this all uses strings from install/ rather than lang, so I have updated stringnames.txt accordingly and they'll all be broken until the cronjob that generates them runs.

MDL-12429 Applied and tested François' patches to 1.8, 1.9 and head.

MDL-12429 Applied and tested François' patches to 1.8, 1.9 and head.

MDL-12790 highlighting in admin search results breaks html
MDL-12791 add defaults parameter to format_admin_setting()
MDL-12792 search in admin settings and defaults
+ minor speedup of fast highlighting and fixed empty span tags

merged from MOODLE_19_STABLE

MDL-7242 eliminate last use of location to refer to city in profile where
it causes problems for translators
merged from MOODLE_19_STABLE

MDL-11561 improved text filter cache resetting when settings change; fixed bug causing fatal errors if html purifier enabled during upgrade; merged from MOODLE_19_STABLE

MDL-12718 show the print_header navigation warning only if in DEBUG_DEVELOPER mode; merged from MOODLE_19_STABLE

MDL-7493 further fix: strip_tags from title strings because the titles may have HTML in them.
  -From Martin D/moodler in moodleblock.class.php - thanks.

MDL-12676 - generate navigation if none supplied to print_header_simple()

Merged from MOODLE_19_STABLE, also merged unmerged change from MDL-11812

New option on print_single_button to all printing of disabled buttons.

Fixes reopened MDL-7493 "Make sure standard themes are visible under "Windows High Contrast Black" mode" - foreground show/hide block icon/ALT text switched with Javscript.

Testing commit message one more time, I think this is it

Testing a commit

Testing a commit message

Improving phpdocs for when to use format_string()/format_text() based on
wiki comments. It wasn't an entirely clear (e.g. mixup in MDL-11800)

Merged from MOODLE_19_STABLE

MDL-12592 do not execute theme_setup() if header already printed; merged from MOODLE_19_STABLE

MDL-12221 reworked container autoclosing - error() and notice() do not work everywhere though; notice print header if needed now; new print_footer('empty') for empty footer - removes some hacky </body></html> - merged from MOODLE_19_STABLE

Fixes MDL-12539 "Help link text for all admin/user filters are broken".

weblib: Fix typo in print_table() which was causing invalid <th> tag
MDL-11506

Fixes bug MDL-12416, Help links - img ALT text should contain phrase "new window" to match link TITLE.

MDL-10915, additional setting for emoticons

Code style corrections.

Possible fix to MDL-12093 : give window without heading and navigation special css classes.

MDL-12093 : cleanup & simplify code to get popup windows.

Adding new wraplevelXX class for easier containers identification. MDL-12339

Merged from MOODLE_19_STABLE

MDL-12221 custom themes revisited - fixed bug in previous commit, added more developer debug; merged from MOODLE_19_STABLE

MDL-12221 custom themes revisited - implemented container concept; merged from MOODLE_19_STABLE

MDL-12284 Moved require_js to weblib and improved it so that it works if called during header (also tidied up code)

MDL-12172 - Sorry, more fall-out from converting continue buttons to use GET instead of POST. Sometimes, URLs were being passed in with & already repalced by & and we weren't handling that properly. Should now be fixed. Merged from MOODLE_19_STABLE.

MDL-12172: fixed get parameters not being submitted in Firefox


Author: Matt Clarkson <mattc@catalyst.net.nz>

fixed typo throwing warnings during install; merged from MOODLE_19_STABLE

MDL-12221 initialised $output and fixed whitespace; merged from MOODLE_19_STABLE

merged from 1.9 :: MDL-12221 :: Added wrapper functions for print_box, print_box_start and print_box_end to be able to add custom_corners to any boxes.

If you call print_custom_corners_box with the same parameters as print_box and custom_corners is enabled you get the custom corners divs within those boxes and can style them accordingly.

MDL-12172 - print_continue should create a method="get" button, not post. Merged from MOODLE_19_STABLE.

MDL-12153, "Validome - moodle.org invalid - require Content-Script-Type".

merged from 1.9 :: MDL-12093

merged from 1.9 :: MDL-12093 :: added function get_in_popup()

support for styles.php in grade reports

Fix for reopened bug MDL-7878, "Link identification and skipping" - includes site and course index.php.

Partial fix for reopened bug MDL-7878, "Link identification and skipping" - affects all course formats + other files.

MDL-11061 - admin notifications about $CFG->wwwroot, which sometimes lead to obscure errors. Merged from MOODLE_19_STABLE.

Follow up fix for MDL-11436 'Encapsulate "accesshide" HTML class in function', and use.

MDL-11699 - Making one more common case a bit nicer for callers. Merged from MOODLE_19_STABLE.

MDL-11699 - Further, backwards-compatible, improvement to the build navigation API to simplify a common case. Also, further improvements to the doc comment, so it is easy to use. Merged from MOODLE_19_STABLE.

MDL-11699 - Addendum - fix typo in fixup code. Sorry.

Fixes MDL-11695, Skip block links inaccessible for many keyboard-only users

Small tidy-up in print_header_simple. Merged from MOODLE_19_STABLE.

MDL-11699 - Addendum - rewrite the other half of the function too, so I can understand what it is doing, and fix a couple of minor logic errors along the way. Merged from MOODLE_19_STABLE.

MDL-10296 adding in the global for https

MDL-11699 - Make build_navigation more helpful by having it optionally build the activity and activityinstance links too, if you pass a $cm object. Note that this only does extra DB queries if you do pass a $cm object, and it does not have all the required fields, but in this case it will winge at you in developer debug mode. If you get your $cm using get_coursemodule_from_instance or get_coursemodule_from_id, which is best practice these days, then you won't have a problem.

Updated copyright notice in header

MDL-11681 Changed it so current tab no longer is a link to #

Fixed typo from MDL-11642, thanks Gary

using correct capability for displaying activity report link in print_user()

MDL-11521 fixed problems when creating contexts and aprents does not exist yet
MDL-11527 fixed warning from $CFG->defaultuserroleid when installing and upgrading
+ removed reusing of previous contexts in has_capability() and get_context_instance()  because it was hiding critical errors when context was false, not specified, etc.
+ tweaked roles defaults - faster and defaults are applied when roles exist
+ SYSCONTEXTID may be specified in config.php to eliminate 1 db query
+ static context cache is now reset after rebuilding of context paths
+ path field in context table is now nullable - pg compatibility requirement
+ other minor fixes

Small efficiency improvement for print_user_picture() when it does access the db