Log of /moodle/mod/forum/search.php

MDL-20204 converted paging_bar to new coding style + fixed regressions from recent commits

MDL-20204 legacy time selects converted, please note we should always use mforms if possible

MDL-21403 getting rid of all asaps

MDL-21240 shortened urls now start with / everywhere

MDL-21235 fixed select method name

MDL-21235 more conversion to new select

MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions

forum MDL-21086 cleaned up boilderplates and php doc packages

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

mod-forum MDL-19808 Added set_url calls, replaced deprecated functions

forum MDL-19808 Upgraded print_header and build_navigation calls to OUTPUT/PAGE equivilants

MDL-19808 Upgraded calls to helpbutton, print_simple_box* and notify

MDL-19808 Upgraded calls to choose_from_menu

MDL-19756 Renamed moodle_select to html_select for better API consistency

MDL-19808 Converted calls to print_paging_bar

MDL-19808 Converted all print_footer() calls

MDL-19808 Migrated calls to print_heading

MDL-19808 Upgraded calls to print_time_selector and print_date_selector

MDL-19808 Upgraded calls to print_time_selector and print_date_selector

mod-forum MDL-16706 Removed inline JS and replaced with new PAGE methods

mod-forum MDL-19620 Replaced get_db_family with get_dbfamily

modforum MDL-16706 Removed inline js script call in mod forum

MDL-18902 reimplemented trusstext support in forum + standardising format column for text fields

MDL-17130 dml: eliminated $CFG->dbfamily

MDL-14129, remove error() in forum mod.

MDL-15189 magic quotes finally removed

MDL-15108 Upgrade finished, preliminary tests successful. Please continue testing.

MDL-14679 converted some get courses

MDL-14349 adv forum search accessibility; merged from MOODLE_19_STABLE

MDL-14349 adv forum search accessibility

MDL-14129, remove all the other error() call

$cours typo fixed

$cours typo fixed

MDL-13450 and MDL-13303 - sorry for changing forum API so late, but it was needed; major perf improvement for forum; fixed printing of user pictures; merged from MOODLE_19_STABLE

MDL-13450 and MDL-13303 - sorry for changing forum API so late, but it was needed; major perf improvement for forum; fixed printing of user pictures

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker; merged from MOODLE_19_STABLE

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker

Backporting small changes from Head

Add some documentation

MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.

This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.

Backported from head. Will update merged tags in a few hours. I am late for orchestra. Sorry.

MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.

This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.

Better solution for MDLSITE-152

FIx the links that were removed by format_string in 1.8   MDLSITE-152

MDL-10888: groupings - mod/forum - add support for groupings, use new groups functions

MDL-10533 - forum search results were having format_text applied twice, which was breaking things like glossary links.

Starting work on MDL-10533 - Eliminate one totally evil abuse of $SESSION. Also, document forum_print_post.

Merged fix for full link to post in search results , from stable

Fixed a broken link to full post in searches

MDL-9473: Initialise navlinks array before use


Author: Matt Clarkson <mattc@catalyst.net.nz>

MDL-9615: Correct incorrect use of term breadcrumbs

- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>

MDL-9780 Groups 181 cleanup - merged from MOODLE_18_STABLE

MDL-9780 Groups 181 cleanup - part 2

MDL-9474: Updated build_navigation() to use global $COURSE

- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>

Breadcrumbs: mod/forum changes

- Modified to use build_navigation() for breadcrumb generation.


Author: Matt Clarkson <mattc@catalyst.net.nz>

Restoring changes all the changes in MOODLE_16_STABLE since MOODLE_16_BETA.

This had to be done because the MOODLE_16_STABLE branch tags were moved.

Hopefully after this MOODLE_16_STABLE will be back to how it was (and a
proper branch) but some of the history may look a bit odd.

See MDL-9032 for more discussion and details.

MDL-8832 : Undid the stripslashes and changed calls to s($string) to s($string, true) instead.

MDL-8832 : Undid the stripslashes and changed calls to s($string) to s($string, true) instead.

MDL-8832 : Added stripslashes around search parameters (6 in total).

MDL-8831 - Forum search boxes date checkboxes loose their checked status. Merged from MOODLE_18_STABLE

MDL-8831 - forum date checkboxes loose their checked status

Merged fixes from stable for MDL-8741

Undoing some of my previous fixes, which are better fixed by the change to groupmode() just made

MDL-8741

Some more uses of $CFG->dbfamily. MDL-7061

MDL-8062 Remove name attribute from <form> and related javascript code cleanup (tested with FF, IE, Konq and Opera)

MDL-8049 Remove all language=Javascript from javascript includes

XHTML fixes for MDL-7861.

Merged fix for MDL-6615.

Fix for MDL-6615. Patch by Luis Peralta.

Converted forum searches so that they take into account the new Roles system. Search results will only include what the searcher should be able to see based on his/her capabilities.

Disable regexp searches for MSSQL and Oracle

trusttext implementation in Forum module, fixed incorrect merging, added missing postresql upgrade code, some other minor fixes

SWEEPING CLEANUP

The API was changed slightly so that has_capability now takes the
whole $context object (we almost always have it anyway)

The $kill thing was removed.   If you want to assert a capability
then use:

    require_capability('capname', $context);

with optional variables to modify the error message

Misc bugs here and there also removed and code tidied

ROLES AND PERMISSIONS  - FIRST CHECK-IN
=======================================

WARNING:  DEV IS CURRENTLY VERY UNSTABLE.

This is a mega-checkin of the new Roles system.   A lot of changes have
been made in core and modules.

Currently there are a lot of rough edges and known problems.  We are
working hard on these .. .the reason for getting this into HEAD at this
stage is enable us to move faster (our branch was diverging from HEAD
too much).

Please keep an eye on http://docs.moodle.org/en/Roles for current status
and information for developers on how to use the new Roles system.

Bug #5909 - Fix use of user_group() because it returns arrays now - part 2 forum search fixed too; merged from MOODLE_16_STABLE

Bug #5909 - Fix use of user_group() because it returns arrays now - part 2 forum search fixed too

New forum type: question and answer: requires students to post their answer before being able to view other posts. After initial post, students can view & respond normally

Merged with MOODLE_16_MULTIENROL_MP1

Moved Embargoed Announcements related search into SQL. So that paging/counting for the search results will be accurate.

Made forum search page aware of Embargoed Announcements

Fixed typo so dateto uri parameter works.

Merged fix from stable

Fixed paging on forum search

Merged search results fix from stable

FIxed a problem when stripping terms from search string for highlighting

10 per page by default

Dealing with forumid and forum_print_post in a more coherent way  ... bug 3047

Add link for advanced searching

Now discussion->name works under filterall.

Now post->subject works under filterall too.

Now the FIRST string working under CFG->filterall is done:
    forum->name
(everything tested but email)

(I'm going to maintain a list of strings in Developers Wiki)

Simplified by removing two optional parameters from forum_print_search_form,
because everyone was using the same values for them!

Also renamed the function to simply forum_search_form, because in the end
noone was using it to PRINT html, it was just put into a variable.

Show last search in the mini search bar

Finishing off search capability with the ability to search by instance,
and in this case, by forum.

Use s function to print search string properly

Disable dates if not being used.
Fixed bug that wasn't highlighting search words

Forum searching now allows searching by date, and no longer has confusing help.

Much better "full" search page.  Still needs some polishing.

Also, you can now search for all posts by one user.  Which brings me to my
next check-in....

Added search help to the small search forms (big search form coming next)

In order to ensure that when a teacher hides a resource or an activity that students really can't get at it, even if they know the direct links to its pages, I have given an optional third argument $cm to the functions  require_login() and require_course_login(). Pages showing information about a particular course module now pass the course module object in this third argument. The login functions will then test if either the course module is visible or the user is a teacher. If neither is the case then the user is redirected to the course homepage after being shown a message "Sorry, this activity is currently hidden".

(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)

Forum search now no longer shows posts from other groups from forums that are in separate groups mode, see bug 2308

Cleaned up some bodgy search code and formatted according to guidelines ..

Highlight search terms found only in HTML markup

FIxes from tony for highlighting

Fixed xml again (bug 2413)

MAJOR NEW FEATURE:  Tracking of read/unread posts

Many thanks to Mike Churchward for his work on this and persevering
with sending updated versions to me.  :-)

Shane and I have polished it up, rewritten a few parts (display-related)
and here it is, finally in CVS!

I think there will still need to be some optimisation for the SQL,
since it's still pretty intensive. Perhaps some sort of caching in
the session that gets modified along with the database whenever
something gets read.

However if there are problems the whole thing can be switched off
in the forum module config so this is not crucially urgent.

Searching was still calling $usexml   Bug #2413

_ added the DIV framework for new CSS

Resolved problems with previous replacement of
& to & and fixed redirect() to entity encode the
inut where needed.
Julian Sedding

XHTML compliance
- fixed (hopefully) all <img> tags
- global replace on <br> to <br />
- &amp; in URLs
- got the forum module XHTML compliant
Julian Sedding

fixed capitalization and quoting of attribute values

All modules are now suitable for the site page. They now all follow the same rules, namely that any students enrolled in at least one course is considered to be a student on the site.

All the page headers work correctly also on the site course.

On the site page the modules don't require login unless necessary or required by $CFG->forcelogin.

Site option forcelogin is now respected by /mod/forum/search.php, fixing bug 1566

Site option forcelogin is now respected by /mod/forum/search.php, fixing bug 1566

Whoops typo

Improved fix to $search variable

Fixing up some handling when searching for strings with quotes in them

Add navmenu to header of forum search pages

Search results link use the anchor tag rather than parent for better context

Even nicer interface with help

tweak

Slightly neater help

Searching forums now has proper paging.

Looks better when nothing is found

Better button behaviour

Much improved forum searching, with independent words and paging

New highlighting function that is able to cope with HTML.

It's a bit slower, but links in forums no longer cause problems.

See bug #589

Clean sweep through all the important changing all include(), include_once()
and require() to require_once()

More database tweaks and improved access to forum search engine

Changes throughout Moodle to remove any reserved words from the
Moodle tables.

ie user -> userid in many tables, plus in user_students
   start -> starttime and end -> endtime

I've just done all this as carefully as I could ... I don't think
I missed anything but it's pretty intensive work and I'd be fooling myself
if I didn't think I'd missed a couple.

Note that this version should pretty much be able to bootstrap itself
using PostgreSQL now ... but this is untested

Many many changes lumped in here ... not finished yet either.

Basically all the Database functions are in lib/datalib.php
and the web functions are all in lib/weblib.php, so
moodlelib.php is much thinner than it was.

Data functions have been extended ... most old calls will
still work, but now many more SQL commands can be performed
using the datalib functions rather than using SQL.  I'm
currently moving through the whole tree replacing SQL
calls or at least concentrating them in one section of
mod/xxx/lib.php

Still working on forums, quizzes, surveys, resources.

The tree is currently not full working ... some things are
half-completed ... will resume tomorrow.

Highlight matches in post subject and discussion name too

Add searching of subjects as well as messages

Fixed some more missing strings

Language fixes

Widespread changes throughout Moodle to make sure it works on
servers that have register_globals turned off (this is the
default setting on newer version of PHP).

In fact it's partly a hack that globalises all GET, POST, FILES
AND COOKIE variables.  Unfortunately though the SESSION and
USER global session variables are only available as $_SESSION["USER"]
and $_SESSION["SESSION"], which is cumbersome to use.

So, for every request I now make a copy of these two session variables
into $USER and $SESSION.  Whenever I update them thoughout Moodle I
now have to call save_session("USER") which copies them back to the
session variable.  This seems to be working well now.

Because I'm using $_SESSION etc now this will raise
the required minimum version of PHP to 4.1.0

Lots of work on site display, over many files.  Improved front page
and display of site modules.

Fixed up some forum functions and constants (consistency)

A big clean up of all the forum functions (including renaming them all
to start with forum_ ) and all the follow-on effects that caused
Some miscellaneous bug fixes and code clean-ups along the way

Fixes to logging and log display

OK, some massive changes with many files removed or changed.

Basically the changes are:

 - I've merged the 'discuss' module into the forum module
   which makes the interface MUCH clearer for everyone
 - I've added a new 'single' forum type that replicates
   what the old discuss course modules used to look like.
 - I've got rid of the "discussion" forum type - it will
   still exist in upgraded courses but as a normal forum.
 - the 'discuss' module is completely deleted - gone.
 - the 'chat' module is completely deleted - gone.
 - The upgrading system has been improved, and all code
   is stored in version.php.
 - I've put in upgrading commands to do the best I can
   (right now) to upgrade courses that used the discuss
   module.  It should mostly work, just leaving some
   "orphan" coursemodules on you course front page.  You
   can easily delete these using the little 'x'.
   I may have forgotten something  - I've only tested on
   my testing server and I'm about to test on my production
   server to see how it goes.
 - Forums have a lot of little new features and fixes.  The
   main one is the subscription process.  Teachers can 'force'
   subscriptions on any forum.  This disallows everyone from
   choosing their own mail subscription - it's just on.
 - The assignment module is half-finished and not working yet

I've still some massive changes to do, mostly involving making
all the lib.php function names more standardised, so consider
this is an interim checkin to do some tests.