Log of /moodle/mod/hotpot/review.php

MDL-21532 ->in_head() now really exceptional (after overrlib removal there will be just a few of them)

MDL-21240 shortened urls now start with / everywhere

MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions

MDL-21198 $OUTPUT->single_button() resurrection, hopefully much easier to use than $OUTPUT->button(); fixed some regressions and code style improvements

MDL-21198 going back to the original spacer syntax, image component improvements, plus some regression fixes

mod-hotpot MDL-20258 Added skeleton functions to extend navigation and removed update this module buttons

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

mod-hotpot MDL-19810 Added set_url calls, replaced deprecated functions

overlib MDL-19735 Overlib is now included only where it is used
At the same time I have converted the calendar block to use YUI instead of overlib, this introduces one regression in that the panel is shown immediatly but should really have a minimal delay for usability.
This will be fixed once the theme changes for 2.0 have been commited

mod-hotpot MDL-19810 Updated print_header and build_navigation to OUTPUT and PAGE equivalents

MDL-19810 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno

MDL-19810 Upgraded calls to helpbutton, print_simple_box* and notify

MDL-19810 Converted all print_footer() calls

MDL-19810 Migrated calls to print_heading

MDL-19810 Migrated calls to print_spacer()

MDL-15110 towards hotpot dml conversion

"MDL-14129, fix print_error"

MDL-14129, remove all the other error() call

MDL-14128, remove all error(getstring()) to print_error()

MDL-14128, remove all uses of error(get_string())

remove trailing whitespace on every line and standardize line endings

remove trailing whitespace on everyline and standardize line endings

fix for Moodle 1.8 and 1.9 to allow students to access hidden hotpots which form part of a hotpot chain - see http://moodle.org/mod/forum/discuss.php?d=91861. In Moodle 1.8 and later the "require_login" function (lib/moodlelib.php)  is stricter than in earlier versions of Moodle and checks a module's visibility and groupings access. From Moodle 2.0 on, this HotPot module does not need this fix.

fix for Moodle 1.8 and 1.9 to allow students to access hidden hotpots which form part of a hotpot chain - see http://moodle.org/mod/forum/discuss.php?d=91861. In Moodle 1.8 and later the "require_login" function (lib/moodlelib.php)  is stricter than in earlier versions of Moodle and checks a module's visibility and groupings access. From Moodle 2.0 on, this HotPot module does not need this fix.

MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.

This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.

Backported from head. Will update merged tags in a few hours. I am late for orchestra. Sorry.

MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.

This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.

MDL-10890 all require_login() in modules reviewed and fixed use of $cm

MDL-9473: Initialise navlinks array before use


Author: Matt Clarkson <mattc@catalyst.net.nz>

MDL-9615: Correct incorrect use of term breadcrumbs

- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>

MDL-9474: Updated build_navigation() to use global $COURSE

- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>

Breadcrumbs: mod/hotpot changes

- Modified to use build_navigation() for breadcrumb generation.


Author: Matt Clarkson <mattc@catalyst.net.nz>

Restoring changes all the changes in MOODLE_16_STABLE since MOODLE_16_BETA.

This had to be done because the MOODLE_16_STABLE branch tags were moved.

Hopefully after this MOODLE_16_STABLE will be back to how it was (and a
proper branch) but some of the history may look a bit odd.

See MDL-9032 for more discussion and details.

Merged Nicolas' changes from MDL-8582 into HEAD.

Fixed MDL-8582
Not sure if the hotpot module is converting ampersands correctly. $heading and $title are set up differently than in other modules: instead of outputting $course->title, a temporary $title variable is created and assigned that value. That made it difficult for me to decide whether it was already formatted elsewhere or not.

Also I didn't format_string() any of the variables included in $navigation rings, because I assume these strings get processed by print_navigation(), which includes format_string().

accessibility fixes

fixed obsoleted use of course->category to find site course - now used SITEID instead MDL-1899

added PARAM types for all calls to "optional_param()" and "required_param()"

fix undefined variable $context on line 135

added some capabilities

new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283; backported from HEAD

new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283; backported from HEAD

Removed tabs

new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283

Changed all files to DOS and added some Id tags

Merged with MOODLE_16_MULTIENROL_MP1

removed bad newlines, which caused double-spacing in PHP source

added some reporting for HP5 (v5 and v6) quizzes; improved reporting on JCross and JQuiz multichoice; some modifications to prepare for upcoming "mobile" output format; corrected positioning bug when IE displays feedback box on long reading

changes to database and most scripts to allow enhancements for HotPot v2.1
  - click-by-click reporting
  - manipulate "chains" of hotpot activities
  - standardized reporting across all quiz types
  - several smaller features

Hotpot module v2!   Thomas Robb, Gordon Bateson - thanks!!