Log of /moodle/mod/quiz/lib.php

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

on-demand cvs snapshot

weekly cvs snapshot

on-demand cvs snapshot

weekly cvs snapshot (2.1beta)

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

weekly cvs snapshot

MDL-25316 quiz_get_extra_capabilities() does not need to fetch subcapabilities explicitly

quiz recent activity MDL-24528 was setting the activity userid to the attempt id. Doh!

MDL-24321 switching to standard stdClass()

MDL-24321 switching to stdClass in /mod/

MDL-22151 & MDL-22138 - Quiz activity backup & questions banks too!
CV S: ----------------------------------------------------------------------

hmm, it is reset course not courses

a few spelling fixes

MDL-16094 File storage conversion Quiz and Questions

quiz navigation: NOBUG link should be imperative, edit quiz, not editing quiz.

mod_quiz / navigation MDL-20276 further polishing the quiz navigation structure.

quiz MDL-22691 error when editing a block's config on the quiz view page.

NOBUG more consistent use of URLs for the quiz reports.

NOMDL quiz: fixed sql params handling in recent activity report

The $params set were thrown away by array() statement, leading to DML
error.

fixed some comment typos

MDL-21676 user_picture refactoring, reenabling email requirement - towards Gravatar support

quiz global settings: MDL-22808 Cannot turn adaptive mode on globally.
Because of a missing constant definition.

navigation MDL-20276 Fixed up the navigation for the quiz module and question section as per Tim's recommendation.
* Routine navigation through the quiz and question modules
* Fixed navbar through quiz and questions
* Pages headers added throughout
* Added method to turn a navigation node into a tabs array suitable for use with print tabs

quiz recent activity: MDL-22410 permission check was wrong.

quiz recent activity: MDL-22410 permission check was wrong.

quiz settings MDL-21780 more work on group and user setting overrides
The group setting tab is now disabled if there are no groups in the course.
The code also now respects groupings.
Thanks to Matt Petro for this patch.

MDL-20860 quiz grades that had already been formatted for output were being used in database queries.
Which really does not work in locales that use , as a decimal point.

Also, this commit fixes one performance problem in index.php with DB queries in a loop.

quiz: NOBUG fix silly typo.

quiz: MDL-20586 Oops, remove reference to global $DB.

quiz recent activity: MDL-20586 was showing scores even if quiz settings said not to.

Fix started with a patch from Yolanda Ordoñez Rufat but with significant reworking by me.

quiz recent activity: MDL-20586 was showing scores even if quiz settings said not to.

Fix started with a patch from Yolanda Ordoñez Rufat but with significant reworking by me.

navigation MDL-22044 Major navigation structure changes.
Navigation has now been re-ordered in accordance with http://docs.moodle.org/en/Development:Navigation_2.0_structure.
This has led to several changes in the way in which navigation is generated included API changes, most notably using the
navigation_nodes add method now returns the newly added node rather than the key.
At the same time the global_navigation_tree block has been renamed to navigation and settings_navigation_tree to settings.

MDL-16438 separating subplugin detection from the plugin_supports code because it was running into infinite loops in get_string() which is often incorrectly used in lib.php files, but the get_string() itself needs to know about subplugins

navigation MDL-21565 Update this xxx is now automatically added to the nav for all modules by default and is renamed to settings as that is what was being used in the tabs system presently anyway.
The following minor changes were also made:
* Added roles links to the navigation automatically
* Handling of block context for settings navigation
* Tidied up init code for settings navigation

quiz: MDL-16478 Allow different open/close dates, etc. for individual students or groups.

This was implemented by Matt Petro of the University of Wisconsin - Madison Engineering
School and Math Department. Many thanks. Reviewed by and committed by Tim Hunt.

This adds a new Overrides tab to the UI, with sub-tabs Group overrides and User overrides.
Each of those lists all the overrides that currently exist, and lets you manage them and
create more.

When a quiz is being attempted, the override that applies to the current user is combined
with the current quiz settings loaded from the quiz table (normally called $quiz).
If there are both user and group overrides, then just the specific user override is used (more specific).
If the user is in several groups, then the overrides are combined to give the most permissive set of options.

There is one new database table quiz_overrides, to store the overrides.

MDL-21590 fixed recent regression in nav icons - now using new pix_icon instead of urls, have to rework extra icon handling in resources though

mod-quiz MDL-15050 Fixed regression missing global OUTPUT

MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions

MDL-21198 $OUTPUT->single_button() resurrection, hopefully much easier to use than $OUTPUT->button(); fixed some regressions and code style improvements

MDL-21198 improved/simplified $OUTPUT->user_picture() + regression fixes, performance fixes and detected performance problems when printing user avatars

navigation MDL-21177 Removed erroneous DB queries from module extension calls

mod-quiz MDL-19813 converted deprecated calendar event methods

MDL-20787 final switch to new $OUTPUT->pix_url() - yay!

MDL-20204 first batch of major theme changes, some regressions are still there, expect more changes and improvements soon; see tracker for details and list of subtasks

MDL-15050 Grades entered/updated through grader report now get correctly displayed in course user activity reports (commenting on last commit). Merged from MOODLE_19_STABLE

no message

mod-quiz MDL-20276 Created callback methods to expand navigation and settings blocks

MDL-19813 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno

MDL-19813 Converted print_box* to $OUTPUT->box*

quiz: add tracker id to TODO.

MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url
and $CFG->modpixpath to $OUTPUT->mod_icon_url

MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions

MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup

mod lib MDL-19294 Added boilerplate and phpdocs

MDL-7028 global $QTYPES is only available if lib/questionlib.php is included.

pagelib: MDL-12212 eliminate quiz_page

MDL-18910 full support for module intro editor with embedded images

MDL-18910 full support for module intro editor with embedded images

MDL-18910 moving modedit features to modname_supports()

quiz: MDL-18637 fix 1.9-style DB code merged to HEAD by mistake.

Fix typo.

quiz settings: MDL-18583 When a quiz has no grade, make it clear that you can only enter one lot of overall feedback.

When the maximum grade for the quiz is 0, we disable all the overall feedback form controls except for the first, and display an explanitory message.

quiz settings: MDL-18583 When a quiz has no grade, make it clear that you can only enter one lot of overall feedback.

When the maximum grade for the quiz is 0, we disable all the overall feedback form controls except for the first, and display an explanitory message.

quiz outline report: MDL-18285 Show regrade date, not last attempt date.

I also took the opportunity to clean up the code a bit.

quiz outline report: MDL-18285 Show regrade date, not last attempt date.

I also took the opportunity to clean up the code a bit.

quiz settings: MDL-17333 Resolve the interrelations between shufflequestions and questionsperpage.

* change the wording of the settings.
* add a repaginate now checkbox (disabled if shuffle is on).
* JavaScript to automatically check the checkbox when qpp changes.
* (remove some irrelevant return value checks now we use exceptions.)

quiz settings: MDL-18485 Improve quiz settings form

* Reorder form fields to group things more logically.
** and on the corresponding admin page too.

* Set some options to be 'Advanced' by default:
** Apply penalties.
** Each attempt builds on the last.
** Decimal places for question grades.
** The five 'Extra restrictions on attempts' settings. (password, etc.)
* Admins can still change this to suit their institiution at Administration > Plugins > Activity modules > Quiz.
* These new defaults are applied if the admin had not previously set any fields to be advanced.

* Disable some filds when they are not applicable:
** Grading method, if num attempts = 1
** Penaly scheme, if adaptive mode = no
** Each attempt builds of last, if num attempts = 1
** Review after quiz closed options, if no close date.
** Delay between 1st and 2nd attempts, if num attempts = 1
** Delay between later attempts, if num attempts < 3

* Convert quiz.timelimit to be in seconds, for consistency, and ready for the new duration field type (MDL 18500).
** Including ensuring that backup and restore is backwards compatible.

* MDL-5537 New setting, questiondecimalpoints, so, for example, you can show the quiz grade as an integer, but have fractional question grades.
** There is a 'Same as overall decimal points' option, which is the default.

* Improve some field labels.

* Make corresponding changes in the help files.

quiz lib: MDL-17579 should call delete_attempt from questionlib.php rather than trying to do the job itself.

quiz: MDL-14926 New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt. Merged from MOODLE_19_STABLE.

quiz: MDL-14926 New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt.

MDL-17457 migrated all modules to new db/install.php; added upgrade.txt file for devs converting contrib modules

MDL-17849 sql queries not printed by default during upgrade anymore, there is a new config.php only setting $CFG->upgradeshowsql instead

accesslib: MDL-17626 delete the context whenever a block is deleted. This includes a new helper function blocks_delete_all_on_page.

accesslib: MDL-17626 delete the context whenever a block is deleted. This includes a new helper function blocks_delete_all_on_page.

quiz: MDL-17578 Review quiz_get_view_actions and quiz_get_post_actions.

performance: MDL-17577 only include lib/questionlib.php from the few parts of mod/quiz/lib.php that actually need it. Merged from MOODLE_19_STABLE.

performance: MDL-17577 only include lib/questionlib.php from the few parts of mod/quiz/lib.php that actually need it.

MDL-15326 "allow for per report capabilities to replace mod/quiz:viewreports"

MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.

Improve comment.

Refactor getting question bank capabilties in mod/quiz/lib.php - don't hard code them.

Also, functions for getting a URL for editing questions in a particular context, ready for MDL-16409.

MDL-16307: move quiz_get_best_grade() in lib.php, and fix the DB request of quiz_user_complete()

MDL-16263 A way for students to flag/bookmark, particular questions during a quiz attempt for later review.

This is an initial implementation that is now at a working state, but with a few things left to do. It seemed like a good idea to commit it before leaving work on Friday night.

MDL-7010 Convert mod\quiz\config.html to mod/quiz/settingstree.php using the new admin tree system.

MDL-16002 rewritten upgrade locking and better upgrade progress tracking; MDL-16070 Do not use $a[0] syntax in lang packs + various other upgrade improvements and fixes

MDL-16058 - Remove obsolete quiz_question_versions table.

MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors.

MDL-10107   Fixed the definition of message providers ... it now works through files very similar to those for events and capabilities, which makes them easy to add/remove/change as necessary

MDL-15498: Fixes to problems Petr identified with completion system checkin

MDL-15498: Completion system

MDL-11421 context levels fixed in capability definitions, sorting of caps by name, plug-ins may report used core caps, fixed some risks; merged from MOODLE_19_STABLE

MDL-11421 context levels fixed in capability definitions, sorting of caps by name, plug-ins may report used core caps, fixed some risks

MDL-10107 - First check-in of Messaging 2.0 code from Luis Rodrigues, GSOC student.

This new messaging system replaces all the various email_to_user() calls.
They are now replaced by events triggers, and the messages are then
processed centrally according to user preferences and sent to one or more
processors (email, popup, jabber etc...)

This code is not finished yet, a lot of work still has to be done on the
interface.  However, the basic structure is there and should be working.
Luis and I will be reviewing and polishing this heavily in the next few weeks.

MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade"

Fixing typo introduced in 1.282.2.14 version of this file.

Fixing typo introduced in 1.298 version of this file.

MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0

MDL-14679 towards modform conversion

MDL-14679 fixed references to mod.html

MDL-14679 removed all instances of get_records_sql_menu()

MDL-14679 finished moodlelib conversion

Inconsistency between quiz attempt->id and attempt.uniqueid

Inconsistency between quiz attempt->id and attempt.uniqueid

MDL-13978 - Notice when adding a new quiz

MDL-13978 - Notice when adding a new quiz

MDL-11282 Implemented fix. Merging from MOODLE_19_STABLE

MDL-11282 Implemented fix

MDL-12945 changing get_fast_modinfo() section property to sectionnum to prevent conflicts with real cm->section; full recent activity speedup when printing user pictures in forum; merged from MOODLE_19_STABLE

MDL-12945 changing get_fast_modinfo() section property to sectionnum to prevent conflicts with real cm->section; full recent activity speedup when printing user pictures in forum

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker; merged from MOODLE_19_STABLE

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker

mod/quiz: fixed fatal error in quiz_print_recent_mod_activity(); Author: Matt Clarkson <mattc@catalyst.net.nz>
backported from HEAD

MDL-12933 - Bug in mod/quiz/lib.php break MyMoodle - Fix thanks to Eric Merrill.

MDL-12933 - Bug in mod/quiz/lib.php break MyMoodle - Fix thanks to Eric Merrill.

MDL-12829 Removed a hard-coded test integer

MDL-12829 Removed a hard-coded test integer

MDL-12829 Removed a hard-coded test integer

MDL-12829 Applied the sql fix

MDL-12829 Applied the sql fix

MDL-12458 fixed gradebook upgrade/update problems when not grades yet in activities; merged from MOODLE_19_STABLE

MDL-12458 fixed gradebook upgrade/update problems when not grades yet in activities

MDL-9459 - Provide information relating to groups in the summary message "Attemts: 123". Now, depending on the situation, you see one of three messages: "Attempts: 123", "Attemtps 123 (45 from your groups)" or "Attemtps 123 (45 from this group)".

I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.

Merged from MOODLE_19_STABLE.

MDL-9459 - Provide information relating to groups in the summary message "Attemts: 123". Now, depending on the situation, you see one of three messages: "Attempts: 123", "Attemtps 123 (45 from your groups)" or "Attemtps 123 (45 from this group)".

I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.

MDL-7028 rewritten course reset + forum role_unassign cleanup fixes; merged from MOODLE_19_STABLE

MDL-7028 rewritten course reset + forum role_unassign cleanup fixes

Minor whitespace fixups.

MFC: MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS

MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS

MDL-6376 - fix minor errors in the previous commit.

More significantly, this patch changes the '1 Students have made 1 attempts' string.

To start with, this code was being produced in five different places, so I made a function to do the work!. Next, as you can see, it is not gramatical. Also, some people find it confusing, as in MDL-6376.

Therefore, it now just says 'Attempts: 1'.

Merged from MOODLE_19_STABLE.

MDL-6376 - fix minor errors in the previous commit.

More significantly, this patch changes the '1 Students have made 1 attempts' string.

To start with, this code was being produced in five different places, so I made a function to do the work!. Next, as you can see, it is not gramatical. Also, some people find it confusing, as in MDL-6376.

Therefore, it now just says 'Attempts: 1'.

mod/quiz: fixed fatal error in quiz_print_recent_mod_activity()


Author: Matt Clarkson <mattc@catalyst.net.nz>

MDL-11432 eliminated majority of RecordCount uses, added several missing rs_close() - this should help improve perf on some platforms - Eloy says ;-)

MDL-11580 support for hidden state modification in gradebook from activities (quiz now only) - part 1
the hiding/unhiding should be IMO locked in gradebook UI when activity overrides it

MDL-6376 - Include quizzes on the MyMoodle page. Initial implementation by Stephen Bourget, with refinements by Tim Hunt. The logic for which quizzes are listed is very similar to the lesson module.

MDL-6043 - supplimental - make corse reset function update quiz open and close dates. Thanks to Shamim Rezaei for the implementation, which I edited slightly.

MDL-11282 Using notice_yesno(), but not sure how to provide a backlink with the cancel action...

MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE.

MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE.

MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE.

MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me.

Take out duplicate $Id$ CVS tags.

Take out duplicate $Id$ CVS tags.

Take out duplicate $Id$ CVS tags.

Updating grades will update the grade_item too

MDL-10834 - Restore of quiz module may create calendar events without a date/time. Fix thanks to Derek Woolhead. Merged from MOODLE_17_STABLE.

MDL-10834 - Restore of quiz module may create calendar events without a date/time. Fix thanks to Derek Woolhead. Merged from MOODLE_17_STABLE.

MDL-10834 - Restore of quiz module may create calendar events without a date/time. Fix thanks to Derek Woolhead.

Notice on quiz config.html page. - backported from HEAD.

Notice on quiz config.html page.

MDL-9551 minor cleanup

MDL-10759 - Bogus get_context_instance call in quiz_print_recent_mod_activity. Merged from MOODLE_17_STABLE.

MDL-10759 - Bogus get_context_instance call in quiz_print_recent_mod_activity. Merged from MOODLE_17_STABLE.

MDL-10759 - Bogus get_context_instance call in quiz_print_recent_mod_activity

MDL-10690 - Make quiz name a manditory field. Merged from MOODLE_18_STABLE.

MDL-10690 - Make quiz name a manditory field.

MDL-10656 - Way to control when Overall feedback is displayed, independantly of the other sorts of feedback. Also, improve the layout of those settings on the quiz editing form.

MDL-10202 merge raw and final grade tables

MDL-10198 - New code to allow files from quiestion attempts to be stored in moodledata and later downloaded. Code thanks to Adriane Boyd, but checked and modified by me, so we share the blame;-)

MDL-6043 - Implement course reset function for quizzes.

MDL-9551 fixed magic quotes when changing grade_item settings

MDL-9551 Implemented calls of grade_update() function in Quiz

MDL-9608 - Work around Firefox putting the user's password in the quiz password field. Merged from MOODLE_18_STABLE.

MDL-9608 - Work around Firefox putting the user's password in the quiz password field.

Restoring changes all the changes in MOODLE_16_STABLE since MOODLE_16_BETA.

This had to be done because the MOODLE_16_STABLE branch tags were moved.

Hopefully after this MOODLE_16_STABLE will be back to how it was (and a
proper branch) but some of the history may look a bit odd.

See MDL-9032 for more discussion and details.

XHTML Strrrrrrict! on quiz module config page.

Fix errors when config changes are saved.

Merged from MOODLE_18_STABLE.

XHTML Strrrrrrict! on quiz module config page.

Fix errors when config changes are saved.

Xhtml fixes for MDL-7861.

MDL-7861 new class .icon and .iconsmall

Checking in Nick Freear's changes and evolution of Julette White's code
with a few modifications made to the install process) for further work in HEAD.

See MDL-7380 for details.

changes to how we generate the id attribute of forms and the naming convention of forms
migrate blog edit to formslib

* Added setAdvanced functionality see http://docs.moodle.org/en/Development:lib/formslib.php_setAdvanced
* Added MoodleQuickForm method closeHeaderBefore($elementName); http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#Use_Fieldsets_to_group_Form_Elements
* Added moodleform method add_action_buttons(); see http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#add_action_buttons.28.24cancel_.3D_true.2C_.24revert_.3D_true.2C_.24submitlabel.3Dnull.29.3B
* is_cancelled method added to moodleform http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page
* added hidden labels to elements within groups such as the date_selector select boxes and other elements in 'groups'
* quiz/mod.html migrated to formslib
* glossary/edit.html migrated to formslib
* extended registerNoSubmitButton() functionality to automatically add js to onclick to bypass client side js input validation.
* added no_submit_button_pressed() function that can be used in a similar way to is_cancelled() as a test in the main script to see if some button in the page has been pressed that is a submit button that is used for some dynamic functionality within the form and not to submit the data for the whole form.
* added new condition for disabledIf which allows to disable another form element if no options are selected from within a select element.
* added default 'action' for moodleform  - strip_querystring(qualified_me()) http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page

Functions to return SQL fragments for groups. Modules, core... no longer need to refer directly to groups DB tables. (Part of MDL-7380, new groups)

Make General feedback more tolerant of whitespace. Merged from MOODLE_17_STABLE.

Make General feedback more tolerant of whitespace.

Renamed new commentary feature to 'general feedback'.

Fixed syntax error.

adding capabilities

MDL-5270 - give students a feeback comment for their performance in the entire quiz.

Also, along the way I noticed and fixed MDL-6290 student grades not rescaled when quiz maximum grade changed.

Remove horrific code duplication in mod/quiz/lib.php.

Bug 6239 - Allow questions to have some teacher-supplied commentary.

While implementing this, I removed the ~100 lines of very similar code from the top of each question type's editquestion.html template, and moved this to a the function print_question_form_start() in the base class, which uses the template question/type/editquestionstart.html. This is described in more detail here: http://moodle.org/mod/forum/discuss.php?d=51590, and is why this patch makes the codebase 523 lines smaller.

Bug #6206 - Quiz can't be created on some mysql configurations. Merged from MOODLE_1.6_STABLE.

Bug #6206 - Quiz can't be created on some mysql configurations

Making sure timelimit is converted to integer before being written to database, otherwise postgreSQL complains. Closing bug 5401; merged from MOODLE_15_STABLE

Making sure timelimit is converted to integer before being written to database, otherwise postgreSQL complains. Closing bug 5401; merged from MOODLE_15_STABLE

Bug 5247: stop people creating tests with a close date before the open date.

Fix some Eclipse code style warnings.

Making sure timelimit is converted to integer before being written to database, otherwise postgreSQL complains. Closing bug 5401

Christian's code to support time delays

Moved code to delete questions and question categories to lib/questionlib.php
Also fixed bug 4949

Some improvements to delete_question()

Moved the quiz constants into lib.php to keep things simple.

Renaming constants QUIZ_ADAPTIVE and QUIZ_IGNORE_DUPRESP to QUESTION_..... and moved them to lib/questionlib.php because they are used for question-level options.

Multianswer restore now works.
Timelimit is rounded to integer before saving in the database
Some more diagnostic error messages
Towards more plugable question types: $QUIZ_MENU is now populated by the question types themselves.

fixed includes in included files - see bug #4891; backported from HEAD

fixed includes in included files - see bug #4891

Some little fixes and more renaming to cleanly separate question code from quiz code

Renaming tables:
quiz_answers -> question_answers
quiz_categories -> question_categories

Renaming functions:
quiz_get_category_menu -> question_category_menu
quiz_get_category_coursename -> question_category_coursename
quiz_categorylist -> question_categorylist

Towards removing reference to quiz module from the question code

Renaming tables:
quiz_questions -> question
quiz_states -> question_states

Renaming functions:
quiz_delete_question -> delete_question
quiz_get_question_options -> get_question_options
quiz_get_states -> get_question_states
quiz_restore_state -> restore_question_state
quiz_save_question_session -> save_question_session
quiz_state_is_graded -> question_state_is_graded
quiz_extract_responses -> question_extract_responses
quiz_regrade_question_in_attempt -> regrade_question_in_attempt
quiz_process_responses -> question_process_responses
quiz_isgradingevent -> question_isgradingevent($event)
quiz_search_for_duplicate_responses -> question_search_for_duplicate_responses
quiz_apply_penalty_and_timelimit -> question_apply_penalty_and_timelimit
quiz_print_question_icon -> print_question_icon
quiz_get_image -> get_question_image
quiz_make_name_prefix -> question_make_name_prefix
quiz_get_id_from_name_prefix -> question_get_id_from_name_prefix
quiz_new_attempt_uniqueid -> question_new_attempt_uniqueid
quiz_get_renderoptions -> question_get_renderoptions
quiz_print_quiz_question -> print_question
quiz_get_question_responses -> get_question_responses
quiz_get_question_actual_response -> get_question_actual_response
quiz_get_question_fraction_grade -> get_question_fraction_grade
quiz_get_default_category -> get_default_question_category


Renaming constants:
QUIZ_EVENT.... -> QUESTION_EVENT....
QUIZ_MAX_NUMBER_ANSWERS -> QUESTION_NUMANS

Renamed table quiz_newest_states to question_sessions

Avoid error messages in case $quiz->sumgrades is zero, closing bug 4454. Merged from STABLE

Avoid error messages in case $quiz->sumgrades is zero, closing bug 4454

Introduced function quiz_delete_question() and questiontype methods delete_question()

reverting change made by Martin D when going to version 1.230

Merged with MOODLE_16_MULTIENROL_MP1

The bug where an event was not created for closing-time-only-supplied
quizzes also existed when updating a quiz instance (not only adding)...

Fix for bug 4358:

No "Quiz closes" event was created for quizzes which ONLY had a closing date

Merged changes from STABLE.

Not sure I did the right thing on questiontypes/calculated/questiontype.php
Hope I didn't create a bug there.

(can people please remember to merge changes into head whenever they change stable?)

Added code to delete records from quiz_newest_states when a quiz instance is deleted.

When one deletes a course, essay records in the quiz_essay are now deleted

Corrected some table/field names (Merged from MOODLE_15_STABLE)

Corrected some table/field names

Initial checkin of stats (from processing the log table).
I will write up some information about it for the developers wiki.

A bit of code cleanup as suggested by Olaf Rempel in bug 3881

Removed the restriction that the quiz timelimit has to be less than the session timeout

Removed the restriction that the quiz timelimit has to be less than the session timeout

Due date and start date are now optional, as requested in bug 867 and bug 3635

Moved constants into constants.php so that they can be loaded where needed.

More steps towards the separation of questions from the quiz module.

I have introduced the new field $attempt->uniqueid, see http://mantis.york.ac.uk/moodle/mod/forum/discuss.php?d=852#3380

Changed name of the container category a bit and avoided one notice.

Merged from MOODLE_15_STABLE

Changed name of the container category a bit and avoided one notice.

Complete refactor of quiz_delete_course()

Now this function works following this:
- Iterate over every quiz category in the course (following parent-child relationships).
- If the category is being used*, move it to site level (under a container category) and
      mark it as published.
- If the category isn't being used, remove** it completely (questions, instances...) and
      re-parent its child categories.
- Feedback is shown in a table detailing all the changes performed.

* One category is being used if it has one question that is being used in any quiz,
  independently of its publish status.
** Removal of categories (and associated questions) has benn improved but, it won't
  be perfect until bug 3366 was solved.

Tested against some large courses with reused questions and multiple levels of
categories. Seems to work but

PLEASE TEST IT AND SEND ANY FEEDBACK TO BUG 2459
(http://moodle.org/bugs/bug.php?op=show&bugid=2459)

Exactly this function is going to be used in the upgrade script to solve
the orphan categories issue and it must work perfectly!

Merged from MOODLE_15_STABLE

Complete refactor of quiz_delete_course()

Now this function works following this:
- Iterate over every quiz category in the course (following parent-child relationships).
- If the category is being used*, move it to site level (under a container category) and
      mark it as published.
- If the category isn't being used, remove** it completely (questions, instances...) and
      re-parent its child categories.
- Feedback is shown in a table detailing all the changes performed.

* One category is being used if it has one question that is being used in any quiz,
  independently of its publish status.
** Removal of categories (and associated questions) has benn improved but, it won't
  be perfect until bug 3366 was solved.

Tested against some large courses with reused questions and multiple levels of
categories. Seems to work but

PLEASE TEST IT AND SEND ANY FEEDBACK TO BUG 2459
(http://moodle.org/bugs/bug.php?op=show&bugid=2459)

Exactly this function is going to be used in the upgrade script to solve
the orphan categories issue and it must work perfectly!

Use round() instead of format_float() to limit decimal points to a MAXIMUM of $quiz->decimalpoints. format_float() always displays EXACTLY that number of digits after the decimal point which is not really desirable.

Merging in from the MOODLE_15_QUIZREFACTOR branch.
The quiz module now can handle adaptive questions and can render remote questions via RQP web services.

fix handling of adaptive option

introduced new review options scheme, see http://moodle.org/mod/forum/discuss.php?d=16709
tabs also on category.php
new field optionflags in quiz table to provide a more practical way of handling large numbers of yes/no options
delete old teacher preview attempts when the quiz is modified
removed unnecessary question->lenght field
state sequences numbers start at zero
taken out "Edit questions" button from view.php (its a tab now)
$quiz->markindividual is now called $quiz->adaptive and is stored in $quiz->optionflags
sometimes we want none of the tabs selected
mysql.php is in a state of transition.

quiz_user_complete contributed by Hiroto Kagotani

Made some error strings translateable
Let teachers know if they preview a quiz that is not available to students
forcing new attempt no only works when quiz is password protected
Don't print quiz intro on attempt page
On category edit page show only categories that belong to the current course
Allow hiding of page breaks
Don't show question numbers on edit page if questions are shuffled randomly
Move functions used only on edit.php out of locallib.php onto edit.php
Towards taking questionsperpage into account when adding questions
Preview link on report.php no longer opens popup
Fixed bug with paging on review page
Only one "Continue" button on review page and also renamed it to "Close review"

Merged from HEAD

Now xxx_print_recent_mod_activity() supports filterall.
(assignment, forum, quiz and workshop)

Now course/recent.php works under PHP5.
See bug 2828
(http://moodle.org/bugs/bug.php?op=show&bugid=2828)

Merged from MOODLE_14_STABLE

Now course/recent.php works under PHP5.
See bug 2828
(http://moodle.org/bugs/bug.php?op=show&bugid=2828)

Renamed quiz_question_version to quiz_question_versions as suggested by Eloy in bug 2777

Merged from HEAD

Now, at backup time (not restore yet):
- quiz_questions->hidden
- quiz_responses->originalquestion
- quiz_question_version table
are properly exported. Restore code coming soon.

First commit of Julian and Alex's new quiz module code. Still unfinished.

Added require_once for pagelib.php.

Now deleting courses with these activities in works just fine once more!

Each mod is responsible to deleting its own blocks; what I had in mind for
centralizing this wouldn't work out. Use the flexible page_import_types so that
we don't create one more dependency when writing new code.

Quiz doesn't attempt to delete blocks placed in deleted quiz view pages anymore;
this is going to be taken care of from course/mod.php.

Fix for bug 2584:

All floatval() calls changed to (float) casts.

One more use of decimalpoints

Now retrieving only needed fields!

fixed my own type (missing ;)

Taken out some $THEME

Don't forget to kill all our block instances if we are deleted.

Double quotes to single and blah blah.

Minor beautification, plus a detail: if the grade is 0.0, this function
would return a grade of 0, which is obviously not the intent here.

better parameter validation and general code cleanup for edit.php

quiz edit.php now saves changes to the quiz in the database as soon as the teacher makes them, see http://moodle.org/mod/forum/discuss.php?d=17167

Recent activity functions should have been in lib.php, not locallib.php

isteacher() was called incorrectly (bug #2379)

split quiz lib.php into a locallib.php for functions that are only used from within the quiz module and a much smaller lib.php for functions that are used from elsewhere in Moodle.

It is now possible to have also questions in all subcategories listed on edit.php. Because there can be a large number of questions the list of questions is now paged.

The random questions have another option specifying whether they can choose their questions also from subcategories or not. This option is stored in the unused questiontext field.

New feature:
Maximum-number-of-questions-per-page

Hierarchical question categories from mediagonal, see http://moodle.org/bugs/bug.php?op=show&bugid=1947

The teacher now can choose whether to see the advanced quiz
options or not. This is handled as in the resource module. The
"Show advanced options" button is only shown if the admin has
chosen to declare some of the options as advanced.

There are now 4 review options as suggested by Martin in
http://moodle.org/mod/forum/discuss.php?d=16709

Provides separate buttons "Update this quiz" and "Edit questions",
see http://moodle.org/mod/forum/discuss.php?d=16708. To make this
possible edit.php can now be called with a quiz id and it saves
its data itself rather than relying on mod.php.

mod.html now has a "Save changes" and a "Save changes and edit questions" button.

"Attempt quiz now" button gets a different language string for
re-attempts. This is currently set to "Re-attempt quiz".

After viewing the feedback for an attempt the "Continue" button
leads back to the course homepage, as requested in bugs 1224 and
1976. If there is no feedback the user is brought straight to quiz/view.php.

Use the proper preview image 11x11

Changed user interface for adding multiple random questions, see http://moodle.org/mod/forum/discuss.php?d=16531#78785

added alt text to icons

sort category question list by type then name as suggested in http://moodle.org/bugs/bug.php?op=show&bugid=2045
Also removed a PHP notice

When teachers view quizzes (attempting or reviewing) they see a small
link with the actual question id of that question.  The link creates
a popup so that they can edit that question directly.

Fixed event handling. Events must be deleted with delete_event.

Instead of modifying event dates the quiz module currently deletes them and adds new ones. This could be improved in the future.

Question type RANDOM now stores responses just like any other question type.
Therefore all workarounds are removed from lib.php and an isolated workaround is included in random/questiontype.php in order to ensure backward compability.

preparation for new handling of uploaded files (to simplify testing of new code from 1.5dev)

new handling of uploaded files, please TEST, TEST, TEST

Changes for XHTML and accessibility compatibility

Merged default categpory fix from stable

First quiz edit in a new course now always has a default category defined

Changes for XHTML and accessibility compliance

Merged robustness check from stable

A robustness check when dealing with unexpected question data.

Shouldn't ever be needed, but I can't yet see what is causing the
situation I'm seeing on a couple of sites where a question doesn't
have a type, and this solves it neatly.

Merged from stable

Added some robustness

XHTML compliance
- fixed (hopefully) all <img> tags
- global replace on <br> to <br />
- &amp; in URLs
- got the forum module XHTML compliant
Julian Sedding

Fixes bug #1854

fixed capitalization and quoting of attribute values

closed <input /> <br /> <hr />

This hack doesn't work, and it doesn't matter, but I'm leaving it in
in case someone can fix it later

Tidying up Howard's wierd indenting.   ;-)

Added a new preview/test feature for quiz questions, sent in by

  Pavel <paolo@psychpan.waw.pl>

Thanks to Przemyslaw, too!

Fixed some notices

And some more

Fixed bug when calling instance_is_visible()

export filename does not now have .txt extension - this is selected by overridable
method on format.php

No checking is now done on question name and question text.

If question name is empty, then it's assigned to be same as the question text.

The question text can now be empty if people want that.

Took care of some issues concerning the use of
individual quiz files in datasetdependent questions

Fixes for some cases where shortanswer responses contain commas

Changed an error() to a notify() so things can continue as much as possible

New generic tools that allow the creation of dataset-dependent questions
as well as the new question type Calculated that uses this generic support.

Some cleanups with formatting and so on.

Merged fix from stable

Fixes a very rare glitch with attempt numbers that I've seen on one
site and could not find the cause for

Fixed bad regular expression logic in short answer

Quiz refactoring is now merged into the main development code!

I've done some basic testing using existing quizzes trying as
much as I could think of, and it all worked well!

Well done, Henrik!  Great job!

Still, this should be regarded as unstable at least until more
people have had a try.  Please test this thing solidly on new
and old quizzes.

Moved all question type dependency concerning question
editing to their respective questiontypes directories.
In most cases it has only been a matter of moving around some code
but for question type MULTIANSWER (i.e. cloze) some recoding was
made in order to have the question type fit into the same pattern
as all the other question types.

The major refactoring check-in
I have completly reworked attempt.php and review.php and their
framework in order to establish a more generic solution.
The only obvious workaround still in place is for the
question type RANDOM, because it uses two rows in
quiz_responses for what is only one question.
The report 'Regrade attempts' has been reworked the same way.
Still have not done anything about the question editing
but that should not be too difficult.

Refactored the question-type dependent attempt and review functionality.

Except for a few temporary workarounds, attempt.php can now
treat all question types the same way. The reason is a new common
pattern for naming the form inputs in a quiz attempt. All question types
now obey this more comprehensive notation. When there comes up a
chance to refactor the database storage as well it would be very
generic if the response storage could reflect the attempt form precisely
instead of having multiple responses on a single question be stored in
a comma-separated list as it is today...

I have also done some small tweaking and debugging in the way different
question types appear in an attempt or review but that can easily be
retweaked again. One the changes is the use of readonly in the review.

Two new features for quizzes!  (Thanks Shane)

 1)  Quizzes can be restricted by subnet

 2)  Quizzes can require a password to be entered before attempts

Added missing handler for exporting Cloze type questions

An early check-in in order to show the direction of this refactoring. The functionality is supposed to remain unchanged except for a correction of a minor bug in the function quiz_get_attempt_responses. The bug could sometimes have caused RANDOM questions to corrupt SHORTANSWER and NUMERICAL responses containing comma (,)

fixed bug #1556 - implode could be called on non-array data

More question types added to support quiz exports

Fixed mistake in category selection - now correctly shows selected category

Updates to quiztimer
- mark question result to zero if time limit is exceeded

Editing and adding question controls are now disabled where the user does
not have editing rights. Applies to published categories.

Fixes for quiztimer.
- Lets make cheating more complicated, more javascript based.
- Mark attempt to zero if time limit is exceeded over 60 seconds

Added functions to only display categories that the user is actually
allowed to edit. Used in question edit screens

Added function to return category name with course shortname apended
Added functions to read a complete quiz category structure into object
    for development of export functionality - working but partial question
    types at the moment.

QuizTimer modifications added plus necessary files along.

Simpler way to update events for a quiz

Fix for BUg 320 from Bernard Boucher

Quizzes with long periods (longer than 5 days) are now handled
in the calendar as two separate events ... one for open and one for close

bug 1402

Some cleaning up of the navigation bars in quizzes

Use overlib feedback on cloze-style questions

Fixes to prevent users from creating bad quiz questions with not
enough answers in them.

Thanks to Shane Elliott (Ikawhero)

Events associated to hidden activities are now invisible in calendar, using new field 'visible' in table 'event' which is updated each time a course module is hidden or unhidden.

Support for events.

Ouch - I thought I'd checked this in days ago

As showing/hiding "Save my answers" button was based in empty($results),
moved $results->attemptbuildsonthelast to $attemptbuildsonthelast.
This was introduced in my latest CVS version, trying to take out
some notices...solved now.

Take our some notices...

Solved two small typos preventing quiz being deleted properly in
quiz_delete_instance() function:
public----------------------------------->publish
get_record("quiz_attempts")------------->get_records("quiz_attempts")

Multianswer cloze questions now show feedback (you need to hover
your mouse over the answers)

Handle '+' signs in short answers

In shortanswers you can now use \* (ie slash asterisk) to mean a real asterisk

Normally the asterisk is a wildcard

More rubustness