Log of /moodle/mod/survey/lib.php

MDL-20204 more html_link converstions

MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions

MDL-21198 improved/simplified $OUTPUT->user_picture() + regression fixes, performance fixes and detected performance problems when printing user avatars

navigation MDL-21177 Removed erroneous DB queries from module extension calls

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

mod-survey MDL-20262 Upgraded survey module in the following ways
 * Upgraded legacy code to use PAGE and OUTPUT methods
 * Added integration with the new navigation blocks
 * Fixed up several bugs within the download script

MDL-19816 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno

MDL-19816 Upgraded calls to helpbutton, print_simple_box* and notify

MDL-19816 Migrated calls to print_heading

MDL-19816 Upgraded calls to print_headline

MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions

mod lib MDL-19294 Added boilerplate and phpdocs

MDL-18910 full support for module intro editor with embedded images

MDL-18910 moving modedit features to modname_supports()

MDL-11421 context levels fixed in capability definitions, sorting of caps by name, plug-ins may report used core caps, fixed some risks; merged from MOODLE_19_STABLE

MDL-11421 context levels fixed in capability definitions, sorting of caps by name, plug-ins may report used core caps, fixed some risks

MDL-15116 survery dml conversion

MDL-14679 towards modform conversion

MDL-14679 fixed references to mod.html

MDL-14679 remoed all instances of get_records_list()

MDL-14679 fixed some more $db's

MDL-14709 fix call view.pgp => view.php, merged from 19

MDL-14709 fix call view.pgp => view.php

Fixing query to be cross-db. Credit goes to David Mudrak. MDL-14583 ; merged from 19_STABLE

Fixing query to be cross-db. Credit goes to David Mudrak. MDL-14583

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker; merged from MOODLE_19_STABLE

MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker

MDL-7028 rewritten course reset + forum role_unassign cleanup fixes; merged from MOODLE_19_STABLE

MDL-7028 rewritten course reset + forum role_unassign cleanup fixes

Fixes reopened bug MDL-7472, "Explicitly label radio buttons in Survey" - removes use of USER->screenreader using get_accesshide + many other accessibility fixes. MERGED.

Fixes reopened bug MDL-7472, "Explicitly label radio buttons in Survey" - removes use of USER->screenreader using get_accesshide + many other accessibility fixes. MERGED.

Fixes reopened bug MDL-7472, "Explicitly label radio buttons in Survey" - removes use of USER->screenreader using get_accesshide + many other accessibility fixes.

MDL-10888: groupings - mod/survey - updated to use groupings

MDL-10383 - deprecated groups_members_from_sql and friends - we do not need them anymore because we reverted to 1.7 style groups in 1.9

Fixing one SQL that could cause problems with coincidences
in the associative array. MDL-10787

Merged from MOODLE_18_STABLE

Fixing one SQL that could cause problems with coincidences
in the associative array. MDL-10787

Patch from Chris Holmes for MDL-10027, merged from 1.8

Patch for JS problem in MDL-10027  (Chris Holmes did it)

MDL-8425 related fixes

MDL-7861, xhtml strict for survey

Checking in Nick Freear's changes and evolution of Julette White's code
with a few modifications made to the install process) for further work in HEAD.

See MDL-7380 for details.

Functions to return SQL fragments for groups. Modules, core... no longer need to refer directly to groups DB tables. (Part of MDL-7380, new groups)

MDL-7434 all images that convey information should have alt text to convey that information - part 3

fix for MDL-7472, explicitly label radio buttons in survey. Note you need $USER->screenreader flag for this to be active

incrementing qnum so that questions numbers in multi will be unique

fix for MDL-7501, accessiblity of survey questions, duplicating row context

Merged AS keyword fixes from stable  MDL-7207

More rogue AS keywords   MDL-7207

Changed <module>_print_recent_activity() functions so that they don't use $isteacher. However, I've left the $isteacher parameter in the functions, for backward compatibility so as not to break thrid party modules. Should we remove the parameter now?

fixed some long standing and some new problems and SC#249, please consider backporting into STABLE

Initial checkin of stats (from processing the log table).
I will write up some information about it for the developers wiki.

Tabs are out

Variety of small fixes, but mostly related to how the recent activity
block is constructed.  A new function exists to pump these notes out
in a standard way :  print_recent_activity_note.

Module dependencies also updated because of this.

Now retrieving only needed fields!

Removing the THEME variable and adding in classes where appropriate

Changes for XHTML and accessibility compatibility

Lib.php postgresql compatibly fix
graph.php $virtualscales was used uninitilized, fixed.

Added missing ,

Minor changes for XHTML compatibility

XHTML compliance
- fixed (hopefully) all <img> tags
- global replace on <br> to <br />
- &amp; in URLs
- got the forum module XHTML compliant
Julian Sedding

towards XHTML compliance

fixed capitalization and quoting of attribute values

closed <input /> <br /> <hr />

Fix for Bug 1383. Added support for the Critical Incident Survey type in the Complete Activity Reports
(Shane Elliott)

Fixed GHEIGHT, GWIDTH typos ... thanks Prince Eloy!

Fix from Bernard Boucher for situation when no groups members defined

   http://moodle.org/mod/forum/discuss.php?d=6335#29657

Some fixes for display of survey reports

Groups support on Surveys.  Phew.

Complete clean-up of the survey reports.

Frames are GONE.  :-)

Also, a new survey: CIQ = Critical Incident Questionnaire

replaced incorrectly closed html tags, see bug 365

Use fullname function for names

Simply, move the XXXX_get_participants() function from
bottom to the common function area.
See bug 807

Included survey_get_participants() function.

Trying a different tack for recent_activity since the old way was
still producing too much data and overflowing PHP memory on busier
sites (eg moodle.org).

Now, there are more database queries, which is unfortunate, but the
data is much more specific, and no sorting needs to be done, so
this is a performance boost.

I don't know how these will cancel out ... my guess is that very
small sites may be very slightly slower on the course page, but
that large sites will be much faster.

Let's see.

Performance improvements

  - better checking of data before processing
  - used logs are removed to avoid re-processing by other modules

Cleaned up definition of constant COURSE_* values in course/lib.php

Moved COURSE_TEACHER_COLOR out to style sheets where it belongs (.teacheronly)

Added some efficiency when printing recent activity

 - don't print more than one weeks worth of updates
  - don't keep re-parsing logs once they've been used

Show activity log only from visible surveys. Bug #367.

Fixes to survey_get_responses() to make it work better with PostgreSQL
(from Petri Asikainen)

Displayed time formats are now stored in lang files
(see the new strftime* strings) so they can be customised per language

OK a number of small changes here.

Firstly, I'm replacing all use of old-style global variables like
$HTTY_REFERER with their new-style equivalent $_SERVER["HTTP_REFERER"]
Also using $_POST instead $HTTP_POST_VARS  etc

Secondly, if gdversion == 0 (ie GD is not installed) then:

 - users are not even allowed to upload new images
 - graphs now just print a message instead of failing.

this allows Moodle to still be used even if GD is not present

Changes throughout Moodle to remove any reserved words from the
Moodle tables.

ie user -> userid in many tables, plus in user_students
   start -> starttime and end -> endtime

I've just done all this as carefully as I could ... I don't think
I missed anything but it's pretty intensive work and I'd be fooling myself
if I didn't think I'd missed a couple.

Note that this version should pretty much be able to bootstrap itself
using PostgreSQL now ... but this is untested

Changes to use new database stuff

Changed all references of %e to %d to fix strftime on Windows

FINALLY!  Surveys are now translatable!    :-)

Reaaranged the functions into standard and other

Fixed stupidity

Error in the SQL - fixed now

New function to show new surveys in recent activity box

Language fixes

Moved all mod.php functions from modules into lib.php, and
updated course/mod.php to use them there.  No longer need module/mod.php

More cleanups to survey - renamed/moved functions, modernised mod.php

typo

Big clean up of survey functions and removal of deadwood (more to go still though)

Extra space at end of file :-)

Got rid of the user.php code fragments and implemented much cleaner
system which certain-named functions in lib.php ... called from /course/user.php

Slight changes to userdate() function.  It now uses gmstrftime() instead of
gmdate to format times, thus allowing it to take advantage of locale, if set,
to print dates in the appropriate language.  Several userdate invocations
had to be changed, though, to use the different formatting specs.

Slight tweaks to survey display after it's been done (list # of students)

Slightly enlarged graphs to 900 pixels instead of 800.

moodle

Initial revision