Log of /moodle/question/category_class.php

question bank - MDL-20545 need a separate language string for edit question category, as opposed to edit course category.

question bank - MDL-20545 need a separate language string for edit question category, as opposed to edit course category.

MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup

output MDL-19799 Fixed up some set_url calls as well as fixing some regressions caused by recent upgrades

question MDL-19820 Replaced deprecated functions

MDL-19820 Converted print_box* to $OUTPUT->box*

MDL-19820 Migrated calls to print_heading

MDL-19976 Changing redirect($url->out()) to redirect($url). NEVER, NEVER use redirect($url->out())!!! Bad Tim! :p

Remove deprecated function call.

MDL-19690 fix some breakage.

MDL-19690 - eliminate the $OUTPUT->initialise_deprecated_cfg_pixpath horrible hack.

Replace $CFG->pixpath with $OUPTUT->old_icon_url(...) instead.

MDL-19077 - Finish eliminating customcorners-specific code in core.

The custom-corners-specific code now in theme/customcornser/renderers.php
and lib/deprecatedlib.php.

Also, $CFG->pixpath is now causing more problems than ever. If it is
giving your problems, please call $OUTPUT->initialise_deprecated_cfg_pixpath()
as a temporary fix. As you can imagine, we are thinking about a better
long-term fix, which is why that method as a silly, and easy to grep name.

MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup

Question categories. Move code to a more appropriate place.

quiz editing: MDL-18173 Make clear in the UI whether a random question selects from subcategories or not.

question bank: MDL-14434 Cannot edit the only question category in a context.

question bank: MDL-14434 Cannot edit the only question category in a context.

question bank: MDL-17078 Error after deleting a question category.

question bank: MDL-17078 Error after deleting a question category.

quiz editing: MDL-17293 Added a default value to avoid error messages

Added a default value  to the function that passes a page number to avoid error messages.

quiz editing: MDL-17293 changed how the page number to add on is passed to the form for creating a random question

quiz editing: MDL-17293 removed two lines of code that did nothing good but some bad, showing an extra form where it should have not been.

quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.

This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.

question bank category editing: To be honest, I can't rememeber exactly what bug this fixes, but it was a problem I found and fixed while preparing to demo stuff at the Brisbane Moodle Moot. In the process of fixing whatever issue it was (I think it was something to do with the permissions checks in some cases) I cleaned to code up and made it easier to understand, and I trust myself, so I am checking this in.

MDL-12814 typo in CSS class name.

MDL-12814 typo in CSS class name.

MDL-15189 magic quotes finally removed

MDL-15102 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.

MDL-14679 removed all instances of get_records_select_menu()

"MDL-14129, fix print_error"

MDL-14928 - Adding random questions from a category with an apostrophe in the name does not work. Stupid bloody addslashes. Roll on dmllib 2.0.

MDL-14928 - Adding random questions from a category with an apostrophe in the name does not work. Stupid bloody addslashes. Roll on dmllib 2.0.

MDL-10899 - followup - need to move random questions too.

MDL-10899 - followup - need to move random questions too.

MDL-10899 - There is some data associated with some questons that needs to be udpated when moving questions between categories. This commit deals with subquestions, and lays the foundation for fixing the other problem - datasets - which is files as bug 14767.

MDL-10899 - There is some data associated with some questons that needs to be udpated when moving questions between categories. This commit deals with subquestions, and lays the foundation for fixing the other problem - datasets - which is files as bug 14767.

MDL-14129, remove all the other error() call

MDL-14128, remove all error(getstring()) to print_error()

MDL-14128, remove all uses of error(get_string())

MDL-12393 - Layout tweaks on question category editing page. Merged from MOODLE_19_STABLE.

MDL-12393 - Layout tweaks on question category editing page.

Minor whitespace fixups.

MDL-11398 - Random questions sometimes ended up with names different from the cateogry they were actually picking from. Also, the same random questoin could be used in more than one quiz, in which case editing that question would change two quizzes unexpectedly. The fix is:

* Don't let the user set the name for random questions.
* Instead force the name to be "Random (catname)" (localised) whever the question is created or saved.
* When a category is renamed, rename all the random questions in it.
* Remove the restriction that Jamie seems to have added in 1.9 that was preventing the category of random questions from being edited.

MDL-10952 update help files for new question code

Fix for MDL-10847  No categories showing in category tab when editing a quiz / questions on PHP 4

Removed usage of table aliases with "as" as per MDL-10808

merging MOODLE_19_QUESTIONS with HEAD

Fix query that does not work on Postgres, and eliminate duplicated code.

further work on the MOODLE_19_QUESTIONS branch - backup and restore and file moving fixes.

MDL-10663 - fix stupid typo on the stable branch. Somebody shoot me!

MDL-10661 - another bloody invisiblefieldset bug. Merged from MOODLE_18_STABLE.

MDL-10661 - another bloody invisiblefieldset bug.

Checking for linked files implemented and further changes to question code in MOODLE_19_QUESTIONS branch.

MDL-9868 Add code to cope with detecting and moving associated files

MDL-9884 Prevent moving of a category if it is the only category in a context.

MDL-9885 'Use Permissions from Roles and Permissions System' almost done. Need to allow "Save as New Question" for those who have view permission on a question and add permission in at least one context.

fix for category.php lists. Slight change in listlib api caused breakage.

fixing logic for deleting categories. Converted confirmation form to formslib.

minor typo

new sql to fetch question counts for categories all in one sql query. Question count now included in drop down box.

UI for editing questions changed to support sharing questions in multiple contexts. Also changed import / export and category editing form to use formslib.

started work on MOODLE_19_QUESTIONS branch. Have coded display of question categories page with categories shared in different category levels. Changes made to the db to remove publish and course fields and replace them with contextid field in category table.

oops. Accidentally committed a change in default no of category items displayed which I'd changed for debug purposes. Reverting change.

pass the category list page param from page to page in question bank editing pages.

MDL-9688 removed saving of quiz object in session in question bank code. 'This patch replaces the saving of the quiz object in session variable modform. cmid is passed between pages instead which is also module independent. Also some other improvements to question code to make it work with other modules besides quiz.'

standardizing params for edit question page. All pages now use courseid instead of course or id.

forget to pass page parameter during redirects.

Added redirects after all actions.
Added methods to category class to generate a url from an array of parameters stored in the object.
Cleaned up some old redundant code for actions now processed in list class.

MDL-9437 lib/listlib.php for displaying and editing a nested list of items.  And changes to question\category.php to use the new lists.

Restoring changes all the changes in MOODLE_16_STABLE since MOODLE_16_BETA.

This had to be done because the MOODLE_16_STABLE branch tags were moved.

Hopefully after this MOODLE_16_STABLE will be back to how it was (and a
proper branch) but some of the history may look a bit odd.

See MDL-9032 for more discussion and details.

MDL-8946 - Fix a regression that broke question export.

Also, partially clean up the way that question bank navigation tabs are printed, so the code is not duplicated in the quiz.

Some other miscellaneous code cleaning too.

Merged from MOODLE_18_STABLE.

MDL-8946 - Fix a regression that broke question export.

Also, partially clean up the way that question bank navigation tabs are printed, so the code is not duplicated in the quiz.

Some other miscellaneous code cleaning too.

Give the question bank code sensible PHPdocumentor package names.

replacing fieldsets with divs in small forms

replacing fieldsets with divs in small forms

Merged Nicolas' changes from MDL-8582 into HEAD.

Fixed MDL-8582
Not sure if the hotpot module is converting ampersands correctly. $heading and $title are set up differently than in other modules: instead of outputting $course->title, a temporary $title variable is created and assigned that value. That made it difficult for me to decide whether it was already formatted elsewhere or not.

Also I didn't format_string() any of the variables included in $navigation rings, because I assume these strings get processed by print_navigation(), which includes format_string().

Xhtml fixes for MDL-7861.

MDL-7861 new class .icon and .iconsmall

Xhtml fixes for MDL-7861.

xhtml fixes for MDL-7861.

fix for MDL-7861, strict xhtml

MDL-7054 - Prevent creation of question categories with blank names. Merged from MOODLE_16_STABLE.

MDL-7054 - Prevent creation of question categories with blank names. Merged from MOODLE_16_STABLE.

MDL-7054 - Prevent creation of question categories with blank names.

Fix some Eclipse code warnings. Merged from MOODLE_16_STABLE.

Fix some Eclipse code warnings.

Convert tabs to spaces.

short php tags once more

Removing some more references to quiz from import/export code

Some little fixes and more renaming to cleanly separate question code from quiz code

Renaming tables:
quiz_answers -> question_answers
quiz_categories -> question_categories

Renaming functions:
quiz_get_category_menu -> question_category_menu
quiz_get_category_coursename -> question_category_coursename
quiz_categorylist -> question_categorylist

Towards removing reference to quiz module from the question code

Renaming tables:
quiz_questions -> question
quiz_states -> question_states

Renaming functions:
quiz_delete_question -> delete_question
quiz_get_question_options -> get_question_options
quiz_get_states -> get_question_states
quiz_restore_state -> restore_question_state
quiz_save_question_session -> save_question_session
quiz_state_is_graded -> question_state_is_graded
quiz_extract_responses -> question_extract_responses
quiz_regrade_question_in_attempt -> regrade_question_in_attempt
quiz_process_responses -> question_process_responses
quiz_isgradingevent -> question_isgradingevent($event)
quiz_search_for_duplicate_responses -> question_search_for_duplicate_responses
quiz_apply_penalty_and_timelimit -> question_apply_penalty_and_timelimit
quiz_print_question_icon -> print_question_icon
quiz_get_image -> get_question_image
quiz_make_name_prefix -> question_make_name_prefix
quiz_get_id_from_name_prefix -> question_get_id_from_name_prefix
quiz_new_attempt_uniqueid -> question_new_attempt_uniqueid
quiz_get_renderoptions -> question_get_renderoptions
quiz_print_quiz_question -> print_question
quiz_get_question_responses -> get_question_responses
quiz_get_question_actual_response -> get_question_actual_response
quiz_get_question_fraction_grade -> get_question_fraction_grade
quiz_get_default_category -> get_default_question_category


Renaming constants:
QUIZ_EVENT.... -> QUESTION_EVENT....
QUIZ_MAX_NUMBER_ANSWERS -> QUESTION_NUMANS

Updated question scripts to work in their new location

Moving quiz-independent question scripts to their new location. In a following commit these files will be updated to actually work in their new location.